BLOB download is not being moved to its final destination#36053
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Nov 1, 2024
Conversation
pvollan
added
the
WebKit Process Model
Collaborator
|
EWS run on previous version of this PR (hash fca3174) Details |
cdumez
approved these changes
Nov 1, 2024
Contributor
There was a problem hiding this comment.
std::exchange(m_sandboxExtension, nullptr) is better practice in my opinion for data members that may get re-used after the move.
Contributor
Author
There was a problem hiding this comment.
Ah, good catch, will fix!
Thanks for reviewing!
pvollan
force-pushed
the
eng/BLOB-download-is-not-being-moved-to-its-final-destination
branch
from
fca3174 to
a1b82b6
Compare
Collaborator
|
EWS run on current version of this PR (hash a1b82b6) Details
|
pvollan
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=282453 rdar://138012063 Reviewed by Chris Dumez. This is because we are revoking the sandbox extension to the downloaded file before the system moves the file to its final location. This patch transfers the sandbox extension to the Download object, in the same way we do for standard downloads. This change makes sure that we are not revoking the sandbox extension until the file has been moved to its final location. * Source/WebKit/NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::didFinishDownload): Canonical link: https://commits.webkit.org/286037@main
webkit-commit-queue
force-pushed
the
eng/BLOB-download-is-not-being-moved-to-its-final-destination
branch
from
a1b82b6 to
55447b1
Compare
Collaborator
|
Committed 286037@main (55447b1): https://commits.webkit.org/286037@main Reviewed commits have been landed. Closing PR #36053 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
55447b1
a1b82b6
🛠 wpe🛠 win🛠 ios-sim🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🛠 wpe-cairo🧪 api-ios🧪 mac-wk2🛠 gtk🛠 vision🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 vision-sim🧪 mac-wk2-stress🧪 api-gtk🧪 mac-intel-wk2🛠 mac-safer-cpp🛠 tv-sim🛠 watch🛠 watch-sim