Skip to content

Conversation

@mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Nov 2, 2024

@mwyrzykowski mwyrzykowski self-assigned this Nov 2, 2024
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Nov 2, 2024
@mwyrzykowski mwyrzykowski requested review from tadeuzagallo and removed request for cdumez and rniwa November 2, 2024 06:41
Copy link
Member

@tadeuzagallo tadeuzagallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth mentioning the sample in the commit message or adding a regression test.

@mwyrzykowski mwyrzykowski force-pushed the eng/WebGPU-Transparent-canvases-are-not-supported-in-WebGPU branch from 50c6d8b to a31a11c Compare November 4, 2024 20:49
@mwyrzykowski
Copy link
Contributor Author

Might be worth mentioning the sample in the commit message or adding a regression test.

I added a link since I'm not sure how to test CALayer's (isOpaque) property which is the only point where this breaks.

@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Nov 4, 2024
https://bugs.webkit.org/show_bug.cgi?id=279373
rdar://135563124

Reviewed by Tadeu Zagallo.

The canvas alphaMode defaults to 'opaque', use 'premultiplied' for transparency.

This resolves the lack of transparency with https://webgpu.github.io/webgpu-samples/?sample=transparentCanvas

* Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm:
(WebCore::GPUCanvasContextCocoa::configure):

Canonical link: https://commits.webkit.org/286121@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-Transparent-canvases-are-not-supported-in-WebGPU branch from a31a11c to 1ab851a Compare November 4, 2024 21:53
@webkit-commit-queue
Copy link
Collaborator

Committed 286121@main (1ab851a): https://commits.webkit.org/286121@main

Reviewed commits have been landed. Closing PR #36089 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1ab851a into WebKit:main Nov 4, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebGPU For bugs in WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants