-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[WebGPU] Transparent canvases are not supported in WebGPU #36089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebGPU] Transparent canvases are not supported in WebGPU #36089
Conversation
|
EWS run on previous version of this PR (hash 50c6d8b) |
tadeuzagallo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth mentioning the sample in the commit message or adding a regression test.
50c6d8b to
a31a11c
Compare
|
EWS run on current version of this PR (hash a31a11c) |
I added a link since I'm not sure how to test CALayer's (isOpaque) property which is the only point where this breaks. |
https://bugs.webkit.org/show_bug.cgi?id=279373 rdar://135563124 Reviewed by Tadeu Zagallo. The canvas alphaMode defaults to 'opaque', use 'premultiplied' for transparency. This resolves the lack of transparency with https://webgpu.github.io/webgpu-samples/?sample=transparentCanvas * Source/WebCore/html/canvas/GPUCanvasContextCocoa.mm: (WebCore::GPUCanvasContextCocoa::configure): Canonical link: https://commits.webkit.org/286121@main
a31a11c to
1ab851a
Compare
|
Committed 286121@main (1ab851a): https://commits.webkit.org/286121@main Reviewed commits have been landed. Closing PR #36089 and removing active labels. |
🧪 api-ios
1ab851a
a31a11c
🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-wpe🧪 mac-wk1🛠 wpe-cairo🧪 gtk-wk2🧪 api-gtk🧪 vision-wk2🛠 mac-safer-cpp🛠 tv-sim🛠 watch