Skip to content

Comments

Import updated web-platform-tests/navigation-api/scroll-behavior/scroll-after-preventDefault.html#36162

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
TingPing:pgriffis/navigation/import-wpt-change
Nov 5, 2024
Merged

Import updated web-platform-tests/navigation-api/scroll-behavior/scroll-after-preventDefault.html#36162
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
TingPing:pgriffis/navigation/import-wpt-change

Conversation

@TingPing
Copy link
Contributor

@TingPing TingPing commented Nov 5, 2024 •
edited by webkit-early-warning-system
Loading

cff182d

Import updated web-platform-tests/navigation-api/scroll-behavior/scroll-after-preventDefault.html
https://bugs.webkit.org/show_bug.cgi?id=282575

Reviewed by Tim Nguyen.

Follow up to #36043

Upstream commit: web-platform-tests/wpt@5188826

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/scroll-behavior/scroll-after-preventDefault-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/scroll-behavior/scroll-after-preventDefault.html:

Canonical link: https://commits.webkit.org/286142@main

575ee13

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@TingPing TingPing self-assigned this Nov 5, 2024
@TingPing TingPing added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Nov 5, 2024
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 5, 2024 •
edited
Loading

EWS run on current version of this PR (hash 575ee13)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@TingPing TingPing requested review from annevk and rwlbuis November 5, 2024 00:42
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 5, 2024
@rwlbuis rwlbuis added safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks and removed merging-blocked Applied to prevent a change from being merged labels Nov 5, 2024
@webkit-ews-buildbot webkit-ews-buildbot removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Nov 5, 2024
@webkit-ews-buildbot
Copy link
Collaborator

webkit-ews-buildbot commented Nov 5, 2024

Safe-Merge-Queue: Build #37557.

@webkit-ews-buildbot webkit-ews-buildbot added the merge-queue Applied to send a pull request to merge-queue label Nov 5, 2024
@TingPing @rwlbuis
Import updated web-platform-tests/navigation-api/scroll-behavior/scro…
cff182d 
…ll-after-preventDefault.html

https://bugs.webkit.org/show_bug.cgi?id=282575

Reviewed by Tim Nguyen.

Follow up to WebKit#36043

Upstream commit: web-platform-tests/wpt@5188826

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/scroll-behavior/scroll-after-preventDefault-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/scroll-behavior/scroll-after-preventDefault.html:

Canonical link: https://commits.webkit.org/286142@main
@webkit-commit-queue webkit-commit-queue force-pushed the pgriffis/navigation/import-wpt-change branch from 575ee13 to cff182d Compare November 5, 2024 09:40
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Nov 5, 2024

Committed 286142@main (cff182d): https://commits.webkit.org/286142@main

Reviewed commits have been landed. Closing PR #36162 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 5, 2024
@webkit-commit-queue webkit-commit-queue merged commit cff182d into WebKit:main Nov 5, 2024
@TingPing TingPing deleted the pgriffis/navigation/import-wpt-change branch November 5, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nt1m nt1m nt1m approved these changes

@annevk annevk Awaiting requested review from annevk

@rwlbuis rwlbuis Awaiting requested review from rwlbuis

Assignees

@TingPing TingPing

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TingPing @webkit-early-warning-system @webkit-ews-buildbot @webkit-commit-queue @nt1m @rwlbuis