[::marker] Factor list item marker contents into a struct by nt1m · Pull Request #37170 · WebKit/WebKit

nt1m · 2024-11-26T22:16:46Z

`4881552`

[::marker] Factor list item marker contents into a struct
https://bugs.webkit.org/show_bug.cgi?id=283730
rdar://140595246

Reviewed by Dan Glastonbury.

Factor them into a struct to make it easier to move out painting/content code from RenderListMarker.

Also store the suffix + textWithoutSuffix, instead of generating substrings in various places.

* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue const):
* Source/WebCore/rendering/RenderListItem.cpp:
(WebCore::RenderListItem::markerTextWithoutSuffix const):
(WebCore::RenderListItem::markerTextWithSuffix const):
* Source/WebCore/rendering/RenderListItem.h:
* Source/WebCore/rendering/RenderListMarker.cpp:
(WebCore::textRunForContent):
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::updateContent):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::relativeMarkerRect):
(WebCore::RenderListMarker::TextRunWithUnderlyingString::operator const TextRun& const): Deleted.
(WebCore::RenderListMarker::textRun const): Deleted.
(WebCore::RenderListMarker::textWithoutSuffix const): Deleted.
* Source/WebCore/rendering/RenderListMarker.h:
(WebCore::ListMarkerTextContent::isEmpty const):
(WebCore::ListMarkerTextContent::textWithSuffix const):
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::markerTextForListItem):

Canonical link: https://commits.webkit.org/287107@main

0c63f98

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
~~🛠 🧪 merge~~	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-11-26T22:16:54Z

EWS run on previous version of this PR (hash f49d75c)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~
	⏳ 🛠 tv	~~🛠 mac-safer-cpp~~
	⏳ 🛠 tv-sim
	✅ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2024-11-26T22:22:57Z

EWS run on previous version of this PR (hash b6af753)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-11-26T23:26:50Z

EWS run on previous version of this PR (hash d7c863e)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	~~🛠 vision~~	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	~~🛠 tv~~	⏳ 🛠 mac-safer-cpp
	~~🛠 tv-sim~~
	❌ 🛠 watch
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-11-26T23:29:59Z

EWS run on previous version of this PR (hash f7f0ce4)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 api-wpe~~
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	~~🛠 wpe-cairo~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	~~🛠 gtk~~
	~~🛠 vision~~	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	❌ 🧪 mac-wk2-stress	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2
	~~🛠 tv~~	⏳ 🛠 mac-safer-cpp
	❌ 🛠 tv-sim
	❌ 🛠 watch
	~~🛠 watch-sim~~

webkit-early-warning-system · 2024-11-26T23:34:26Z

EWS run on previous version of this PR (hash 9c2eceb)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	~~🛠 vision~~	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	~~🛠 tv~~	❌ 🛠 mac-safer-cpp
	~~🛠 tv-sim~~
	⏳ 🛠 watch
	~~🛠 watch-sim~~

darinadler

Storing the text as two separate strings causes a problem.

Source/WebCore/rendering/RenderListMarker.h

webkit-early-warning-system · 2024-11-26T23:38:33Z

EWS run on previous version of this PR (hash eff1790)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	⏳ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-11-26T23:48:37Z

EWS run on previous version of this PR (hash e349a63)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	~~🛠 tv-sim~~
	⏳ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2024-11-26T23:56:18Z

EWS run on previous version of this PR (hash 6e39997)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	~~🛠 mac~~	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	~~🛠 ios-sim~~	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	❌ 🛠 wpe-cairo
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	~~🛠 vision~~	❌ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	~~🧪 mac-intel-wk2~~
	~~🛠 tv~~	❌ 🛠 mac-safer-cpp
	~~🛠 tv-sim~~
	⏳ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2024-11-27T00:00:47Z

EWS run on previous version of this PR (hash 53eae61)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 win~~
~~🧪 bindings~~	~~🛠 ios-sim~~	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~
	~~🛠 tv~~	⏳ 🛠 mac-safer-cpp
	~~🛠 tv-sim~~
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2024-11-27T00:01:47Z

EWS run on previous version of this PR (hash a8c64f7)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2024-11-27T00:16:00Z

EWS run on previous version of this PR (hash 811de65)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 win
~~🧪 bindings~~	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	⏳ 🧪 win-tests
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	⏳ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~
	⏳ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2024-11-27T00:17:07Z

EWS run on current version of this PR (hash 0c63f98)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
~~🛠 🧪 merge~~	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

djg

https://bugs.webkit.org/show_bug.cgi?id=283730 rdar://140595246 Reviewed by Dan Glastonbury. Factor them into a struct to make it easier to move out painting/content code from RenderListMarker. Also store the suffix + textWithoutSuffix, instead of generating substrings in various places. * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::stringValue const): * Source/WebCore/rendering/RenderListItem.cpp: (WebCore::RenderListItem::markerTextWithoutSuffix const): (WebCore::RenderListItem::markerTextWithSuffix const): * Source/WebCore/rendering/RenderListItem.h: * Source/WebCore/rendering/RenderListMarker.cpp: (WebCore::textRunForContent): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::updateContent): (WebCore::RenderListMarker::computePreferredLogicalWidths): (WebCore::RenderListMarker::updateMargins): (WebCore::RenderListMarker::relativeMarkerRect): (WebCore::RenderListMarker::TextRunWithUnderlyingString::operator const TextRun& const): Deleted. (WebCore::RenderListMarker::textRun const): Deleted. (WebCore::RenderListMarker::textWithoutSuffix const): Deleted. * Source/WebCore/rendering/RenderListMarker.h: (WebCore::ListMarkerTextContent::isEmpty const): (WebCore::ListMarkerTextContent::textWithSuffix const): * Source/WebCore/rendering/RenderTreeAsText.cpp: (WebCore::RenderTreeAsText::writeRenderObject): (WebCore::markerTextForListItem): Canonical link: https://commits.webkit.org/287107@main

webkit-commit-queue · 2024-11-27T01:37:42Z

Committed 287107@main (4881552): https://commits.webkit.org/287107@main

Reviewed commits have been landed. Closing PR #37170 and removing active labels.

nt1m self-assigned this Nov 26, 2024

nt1m added the Layout and Rendering For bugs with layout and rendering of Web pages. label Nov 26, 2024

nt1m requested a review from alanbaradlay November 26, 2024 22:16

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from f49d75c to b6af753 Compare November 26, 2024 22:22

nt1m requested review from anttijk, darinadler and heycam November 26, 2024 22:51

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from b6af753 to d7c863e Compare November 26, 2024 23:26

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from d7c863e to f7f0ce4 Compare November 26, 2024 23:29

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from f7f0ce4 to 9c2eceb Compare November 26, 2024 23:34

darinadler requested changes Nov 26, 2024

View reviewed changes

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from 9c2eceb to eff1790 Compare November 26, 2024 23:38

nt1m requested a review from darinadler November 26, 2024 23:47

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from eff1790 to e349a63 Compare November 26, 2024 23:48

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from e349a63 to 6e39997 Compare November 26, 2024 23:56

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from 6e39997 to 53eae61 Compare November 27, 2024 00:00

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from 53eae61 to a8c64f7 Compare November 27, 2024 00:01

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from a8c64f7 to 811de65 Compare November 27, 2024 00:15

nt1m force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from 811de65 to 0c63f98 Compare November 27, 2024 00:17

djg approved these changes Nov 27, 2024

View reviewed changes

webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Nov 27, 2024

nt1m added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 27, 2024

webkit-commit-queue force-pushed the eng/marker-Factor-list-item-marker-contents-into-a-struct branch from 0c63f98 to 4881552 Compare November 27, 2024 01:37

webkit-commit-queue merged commit 4881552 into WebKit:main Nov 27, 2024

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 27, 2024

nt1m deleted the eng/marker-Factor-list-item-marker-contents-into-a-struct branch November 27, 2024 01:38

Conversation

nt1m commented Nov 26, 2024 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

4881552

Uh oh!

webkit-early-warning-system commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

darinadler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

djg left a comment

Choose a reason for hiding this comment

Uh oh!

webkit-commit-queue commented Nov 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nt1m commented Nov 26, 2024 •

edited by webkit-early-warning-system

Loading

`4881552`

webkit-early-warning-system commented Nov 26, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 26, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 26, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 26, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 26, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 26, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 26, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 26, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 27, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 27, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 27, 2024 •

edited

Loading

webkit-early-warning-system commented Nov 27, 2024 •

edited

Loading