Skip to content

Reduce use of WTF_ALLOW_UNSAFE_BUFFER in WTF/#37210

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:283775_WTF_safe_buffers
Nov 28, 2024
Merged

Reduce use of WTF_ALLOW_UNSAFE_BUFFER in WTF/#37210
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:283775_WTF_safe_buffers

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Nov 28, 2024

03cb2e5

Reduce use of WTF_ALLOW_UNSAFE_BUFFER in WTF/
https://bugs.webkit.org/show_bug.cgi?id=283775

Reviewed by Darin Adler.

* Source/WTF/wtf/BloomFilter.h:
(WTF::BloomFilter<keyBits>::keysFromHash):
* Source/WTF/wtf/Brigand.h:
* Source/WTF/wtf/ParallelJobs.h:
* Source/WTF/wtf/ParallelJobsLibdispatch.h:
(WTF::ParallelEnvironment::execute):
* Source/WTF/wtf/TinyLRUCache.h:
(WTF::TinyLRUCache::get):
(WTF::TinyLRUCache::cacheBuffer):

Canonical link: https://commits.webkit.org/287158@main

143a062

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Nov 28, 2024
@cdumez cdumez marked this pull request as ready for review November 28, 2024 03:25
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 28, 2024
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Nov 28, 2024
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 28, 2024
Comment on lines 107 to 108
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have put the span into a local instead of repeating the cast twice, even though the old code repeated the pointer expression twice.

@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Nov 28, 2024
@cdumez cdumez force-pushed the 283775_WTF_safe_buffers branch from d6382cb to 143a062 Compare November 28, 2024 18:37
@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 28, 2024
https://bugs.webkit.org/show_bug.cgi?id=283775

Reviewed by Darin Adler.

* Source/WTF/wtf/BloomFilter.h:
(WTF::BloomFilter<keyBits>::keysFromHash):
* Source/WTF/wtf/Brigand.h:
* Source/WTF/wtf/ParallelJobs.h:
* Source/WTF/wtf/ParallelJobsLibdispatch.h:
(WTF::ParallelEnvironment::execute):
* Source/WTF/wtf/TinyLRUCache.h:
(WTF::TinyLRUCache::get):
(WTF::TinyLRUCache::cacheBuffer):

Canonical link: https://commits.webkit.org/287158@main
@webkit-commit-queue
Copy link
Collaborator

Committed 287158@main (03cb2e5): https://commits.webkit.org/287158@main

Reviewed commits have been landed. Closing PR #37210 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 03cb2e5 into WebKit:main Nov 28, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments