Reduce use of WTF_ALLOW_UNSAFE_BUFFER in WTF/#37210
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Nov 28, 2024
Merged
Reduce use of WTF_ALLOW_UNSAFE_BUFFER in WTF/#37210webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash d6382cb) Details |
darinadler
approved these changes
Nov 28, 2024
Source/WTF/wtf/BloomFilter.h
Outdated
Comment on lines
107
to
108
Member
There was a problem hiding this comment.
I would have put the span into a local instead of repeating the cast twice, even though the old code repeated the pointer expression twice.
d6382cb to
143a062
Compare
Collaborator
|
EWS run on current version of this PR (hash 143a062) Details |
143a062 to
d7964f0
Compare
https://bugs.webkit.org/show_bug.cgi?id=283775 Reviewed by Darin Adler. * Source/WTF/wtf/BloomFilter.h: (WTF::BloomFilter<keyBits>::keysFromHash): * Source/WTF/wtf/Brigand.h: * Source/WTF/wtf/ParallelJobs.h: * Source/WTF/wtf/ParallelJobsLibdispatch.h: (WTF::ParallelEnvironment::execute): * Source/WTF/wtf/TinyLRUCache.h: (WTF::TinyLRUCache::get): (WTF::TinyLRUCache::cacheBuffer): Canonical link: https://commits.webkit.org/287158@main
d7964f0 to
03cb2e5
Compare
Collaborator
|
Committed 287158@main (03cb2e5): https://commits.webkit.org/287158@main Reviewed commits have been landed. Closing PR #37210 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
03cb2e5
143a062