[WASM] Default-initialized fields of WASM GC struct should use Const32 if appropriate for storage type#37347
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Dec 3, 2024
Conversation
Collaborator
|
EWS run on current version of this PR (hash 5340f32) Details |
…2 if appropriate for storage type https://bugs.webkit.org/show_bug.cgi?id=283941 rdar://140773922 Reviewed by Yusuke Suzuki and Keith Miller. Generates a Const32Value in OMG instead of a Const64Value when zero-initializing fields in struct.new_default when the field storage types are 32-bit or smaller. This satisfies the B3 validator which expects an Int32 input for Stores of 32 bits or smaller. * JSTests/wasm/stress/struct-new_default-small-members.js: Added. * Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp: (JSC::Wasm::OMGIRGenerator::addStructNewDefault): * Source/JavaScriptCore/wasm/WasmOMGIRGenerator32_64.cpp: (JSC::Wasm::OMGIRGenerator::addStructNewDefault): Canonical link: https://commits.webkit.org/287295@main
webkit-commit-queue
force-pushed
the
eng/WASM-Default-initialized-fields-of-WASM-GC-structs-should-use-Const32-if-appropriate-for-storage-type
branch
from
5340f32 to
a9abb74
Compare
Collaborator
|
Committed 287295@main (a9abb74): https://commits.webkit.org/287295@main Reviewed commits have been landed. Closing PR #37347 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a9abb74
5340f32