[iOS] TouchEventTests.DestroyWebViewWhileHandlingTouchEnd crashes after 286448@main#37352
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Dec 3, 2024
Merged
Conversation
whsieh
added
the
Tools / Tests
Collaborator
|
EWS run on current version of this PR (hash ba2510c) Details |
whsieh
requested review from
aprotyas,
charliewolfe,
hortont424,
pxlcoder and
rr-codes
rr-codes
approved these changes
Dec 3, 2024
Member
Author
|
Thanks for the review! |
charliewolfe
approved these changes
Dec 3, 2024
…er 286448@main https://bugs.webkit.org/show_bug.cgi?id=283955 Reviewed by Richard Robinson. 286448@main refactored `-_touchEventsRecognized:` such that it no longer takes the gesture recognizer as an argument, but didn't update an API test that forward declares and directly calls into this selector on the content view. Fix this by updating the test. * Tools/TestWebKitAPI/Tests/ios/TouchEventTests.mm: (TestWebKitAPI::TEST(TouchEventTests, DestroyWebViewWhileHandlingTouchEnd)): (-[WKWebView touchEventGestureRecognizer]): Deleted. Canonical link: https://commits.webkit.org/287250@main
webkit-commit-queue
force-pushed
the
eng/283955
branch
from
ba2510c to
3744c7e
Compare
Collaborator
|
Committed 287250@main (3744c7e): https://commits.webkit.org/287250@main Reviewed commits have been landed. Closing PR #37352 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3744c7e
ba2510c
🛠 ios-sim🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 ios-wk2-wpt🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 api-gtk🧪 vision-wk2🧪 mac-intel-wk2🛠 tv-sim🛠 watch🛠 watch-sim