Skip to content

Skip anchor-download-redirect-cross-origin.html on WK1#37513

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
nmahendru:eng/New-Test-284937-main-Sequoia-wk1-http-tests-download-anchor-download-redirect-cross-origin-html-is-a-consistent-failure
Dec 6, 2024
Merged

Skip anchor-download-redirect-cross-origin.html on WK1#37513
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
nmahendru:eng/New-Test-284937-main-Sequoia-wk1-http-tests-download-anchor-download-redirect-cross-origin-html-is-a-consistent-failure

Conversation

@nmahendru
Copy link
Contributor

@nmahendru nmahendru commented Dec 6, 2024

a3cc9c5

Skip anchor-download-redirect-cross-origin.html on WK1
https://bugs.webkit.org/show_bug.cgi?id=284068
rdar://140939708

Reviewed by Alex Christensen.

The original fix is only intended for WK2 and there is not plan to add a similar fix for WK1.
The same applies to the test added to validate that fix.
Missing to add [ Skip ] for WK1 originally was an oversight. My bad.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/287418@main

9cb0f94

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style 🛠 ios 🛠 mac 🛠 wpe 🛠 win
🛠 ios-sim 🛠 mac-AS-debug 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac 🧪 api-wpe
🧪 ios-wk2-wpt 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🧪 api-ios 🧪 mac-wk2 ✅ 🛠 gtk
🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
🛠 vision-sim 🧪 mac-wk2-stress 🧪 api-gtk
⏳ 🧪 vision-wk2 🧪 mac-intel-wk2
✅ 🛠 🧪 unsafe-merge 🛠 tv
🛠 tv-sim
🛠 watch
🛠 watch-sim

@nmahendru nmahendru self-assigned this Dec 6, 2024
@nmahendru nmahendru added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Dec 6, 2024
@nmahendru nmahendru requested a review from karlrackler December 6, 2024 00:07
@nmahendru nmahendru force-pushed the eng/New-Test-284937-main-Sequoia-wk1-http-tests-download-anchor-download-redirect-cross-origin-html-is-a-consistent-failure branch from 3919fee to ddaefbd Compare December 6, 2024 00:10
@nmahendru nmahendru changed the title Skipping the test instead of marking it as failure. Skip anchor-download-redirect-cross-origin.html on WK1 Dec 6, 2024
@nmahendru nmahendru force-pushed the eng/New-Test-284937-main-Sequoia-wk1-http-tests-download-anchor-download-redirect-cross-origin-html-is-a-consistent-failure branch from ddaefbd to 9cb0f94 Compare December 6, 2024 00:20
@nmahendru nmahendru added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 6, 2024
https://bugs.webkit.org/show_bug.cgi?id=284068
rdar://140939708

Reviewed by Alex Christensen.

The original fix is only intended for WK2 and there is not plan to add a similar fix for WK1.
The same applies to the test added to validate that fix.
Missing to add [ Skip ] for WK1 originally was an oversight. My bad.

* LayoutTests/platform/mac-wk1/TestExpectations:

Canonical link: https://commits.webkit.org/287418@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/New-Test-284937-main-Sequoia-wk1-http-tests-download-anchor-download-redirect-cross-origin-html-is-a-consistent-failure branch from 9cb0f94 to a3cc9c5 Compare December 6, 2024 00:24
@webkit-commit-queue
Copy link
Collaborator

Committed 287418@main (a3cc9c5): https://commits.webkit.org/287418@main

Reviewed commits have been landed. Closing PR #37513 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a3cc9c5 into WebKit:main Dec 6, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants