[CMake][LibWebRTC] Fix build after 287395@main#37538
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Dec 6, 2024
Merged
[CMake][LibWebRTC] Fix build after 287395@main#37538webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
philn
added
the
New Bugs
Collaborator
|
EWS run on previous version of this PR (hash 3780409) Details |
Contributor
|
I tested the patch on ARM. It's necessary to apply this fix: diff --git a/Source/ThirdParty/libwebrtc/CMakeLists.txt b/Source/ThirdParty/libwebrtc/CMakeLists.txt
index 830859f043ce..705fdc2a2289 100644
--- a/Source/ThirdParty/libwebrtc/CMakeLists.txt
+++ b/Source/ThirdParty/libwebrtc/CMakeLists.txt
@@ -526,7 +526,6 @@ set(webrtc_SOURCES
Source/third_party/boringssl/src/pki/signature_algorithm.cc
Source/third_party/boringssl/src/pki/simple_path_builder_delegate.cc
Source/third_party/boringssl/src/pki/string_util.cc
- Source/third_party/boringssl/src/pki/test_helpers.cc
Source/third_party/boringssl/src/pki/trust_store.cc
Source/third_party/boringssl/src/pki/trust_store_collection.cc
Source/third_party/boringssl/src/pki/trust_store_in_memory.cc |
Collaborator
|
EWS run on current version of this PR (hash b969d46) Details
|
philn
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=284154 Unreviewed, update sources list after the BoringSSL version bump. * Source/ThirdParty/libwebrtc/CMakeLists.txt: Canonical link: https://commits.webkit.org/287445@main
webkit-commit-queue
force-pushed
the
eng/284154
branch
from
b969d46 to
0b975d3
Compare
Collaborator
|
Committed 287445@main (0b975d3): https://commits.webkit.org/287445@main Reviewed commits have been landed. Closing PR #37538 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0b975d3
b969d46
🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-wk2🛠 vision🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 vision-sim🧪 mac-wk2-stress🧪 api-gtk🧪 mac-intel-wk2🛠 tv-sim🛠 watch