Skip to content

ASSERTION FAILED: !waiter->isOnList() in JavaScriptCore#37657

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
hyjorc1:eng/ASSERTION-FAILED-waiter-isOnList-in-JavaScriptCore
Dec 10, 2024
Merged

ASSERTION FAILED: !waiter->isOnList() in JavaScriptCore#37657
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
hyjorc1:eng/ASSERTION-FAILED-waiter-isOnList-in-JavaScriptCore

Conversation

@hyjorc1
Copy link
Copy Markdown
Contributor

@hyjorc1 hyjorc1 commented Dec 9, 2024

4769bb5

ASSERTION FAILED: !waiter->isOnList() in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=284244
rdar://141173936

Reviewed by Yusuke Suzuki.

This patch simplify the log in WaiterListManager::timeoutAsyncWaiter
since the DeferredWorkTimer::TicketData can be canceled at any time.

* JSTests/stress/waitasync-wait-timeout-with-canceled-tickets.js: Added.
(C0):
(i.let.handler.get target):
(i.f28):
* Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp:
(JSC::DeferredWorkTimer::TicketData::cancel):
(JSC::DeferredWorkTimer::cancelPendingWork):
(JSC::DeferredWorkTimer::cancelPendingWorkSafe):
* Source/JavaScriptCore/runtime/WaiterListManager.cpp:
(JSC::WaiterListManager::timeoutAsyncWaiter):
* Source/JavaScriptCore/runtime/WaiterListManager.h:

Canonical link: https://commits.webkit.org/287611@main

47e8b9e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🧪 jsc-armv7-tests
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@hyjorc1 hyjorc1 requested a review from a team as a code owner December 9, 2024 21:06
@hyjorc1 hyjorc1 self-assigned this Dec 9, 2024
@hyjorc1 hyjorc1 added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Dec 9, 2024
@hyjorc1 hyjorc1 force-pushed the eng/ASSERTION-FAILED-waiter-isOnList-in-JavaScriptCore branch from f4bab6c to 47e8b9e Compare December 9, 2024 21:11
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 10, 2024
@hyjorc1 hyjorc1 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Dec 10, 2024
https://bugs.webkit.org/show_bug.cgi?id=284244
rdar://141173936

Reviewed by Yusuke Suzuki.

This patch simplify the log in WaiterListManager::timeoutAsyncWaiter
since the DeferredWorkTimer::TicketData can be canceled at any time.

* JSTests/stress/waitasync-wait-timeout-with-canceled-tickets.js: Added.
(C0):
(i.let.handler.get target):
(i.f28):
* Source/JavaScriptCore/runtime/DeferredWorkTimer.cpp:
(JSC::DeferredWorkTimer::TicketData::cancel):
(JSC::DeferredWorkTimer::cancelPendingWork):
(JSC::DeferredWorkTimer::cancelPendingWorkSafe):
* Source/JavaScriptCore/runtime/WaiterListManager.cpp:
(JSC::WaiterListManager::timeoutAsyncWaiter):
* Source/JavaScriptCore/runtime/WaiterListManager.h:

Canonical link: https://commits.webkit.org/287611@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/ASSERTION-FAILED-waiter-isOnList-in-JavaScriptCore branch from 47e8b9e to 4769bb5 Compare December 10, 2024 17:25
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 287611@main (4769bb5): https://commits.webkit.org/287611@main

Reviewed commits have been landed. Closing PR #37657 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 4769bb5 into WebKit:main Dec 10, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants