Skip to content

[WebDriver][socket] support capabilites.acceptInsecureCerts#37764

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
haruhisa-shin:eng/bug284440
Dec 12, 2024
Merged

[WebDriver][socket] support capabilites.acceptInsecureCerts#37764
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
haruhisa-shin:eng/bug284440

Conversation

@haruhisa-shin
Copy link
Contributor

@haruhisa-shin haruhisa-shin commented Dec 11, 2024

fe03aff

[WebDriver][socket] support capabilites.acceptInsecureCerts
https://bugs.webkit.org/show_bug.cgi?id=284440

Reviewed by Fujii Hironori.

Before this change, win port WebDriver does not check the capabilities.

The W3C spec defines that self-signed or invalid certificates are
implicitly trusted if the value of `capabilities.acceptInsecureCerts`
is true.
https://www.w3.org/TR/webdriver2/#capabilities

For example, the tests in web-platform-tests use self-signed
certificates to start an http server.
Support for acceptInsecureCerts would be helpful to run those tests
over https.

* Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::startAutomationSession):
* Source/WebDriver/socket/SessionHostSocket.cpp:
(WebDriver::SessionHost::startAutomationSession):
* Source/WebKit/UIProcess/win/AutomationClientWin.cpp:
(WebKit::AutomationSessionClient::AutomationSessionClient):
(WebKit::AutomationSessionClient::didReceiveAuthenticationChallenge):
(WebKit::AutomationSessionClient::requestNewPageWithOptions):
(WebKit::AutomationClient::requestAutomationSession):
* Source/WebKit/UIProcess/win/AutomationClientWin.h:

Canonical link: https://commits.webkit.org/287707@main

f01be4e

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style 🛠 ios ✅ 🛠 mac 🛠 wpe 🛠 win
✅ 🛠 ios-sim 🛠 mac-AS-debug 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac 🧪 api-wpe
🧪 ios-wk2-wpt 🧪 mac-wk1 🛠 wpe-cairo
🛠 🧪 jsc 🧪 api-ios 🧪 mac-wk2 🛠 gtk
✅ 🛠 🧪 jsc-arm64 🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
🛠 vision-sim 🧪 mac-wk2-stress 🧪 api-gtk
⏳ 🧪 vision-wk2 🧪 mac-intel-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 unsafe-merge 🛠 tv 🛠 mac-safer-cpp 🧪 jsc-armv7-tests
🛠 tv-sim
🛠 watch
🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Dec 11, 2024
@fujii
Copy link
Contributor

fujii commented Dec 11, 2024

Currently, win port WebDriver does not check the capabilities.

Is this before this change or after this change?
Words "currently" an "now" are ambiguous words in commit messages.
"before this change" and "previously" might better.

@haruhisa-shin
Copy link
Contributor Author

Is this before this change or after this change?
Words "currently" an "now" are ambiguous words in commit messages.
"before this change" and "previously" might better.

Thank you for your advice.
That "Currently" means "before this change".
I'll update the commit log, and take care not to use it again.

@fujii fujii added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Dec 12, 2024
https://bugs.webkit.org/show_bug.cgi?id=284440

Reviewed by Fujii Hironori.

Before this change, win port WebDriver does not check the capabilities.

The W3C spec defines that self-signed or invalid certificates are
implicitly trusted if the value of `capabilities.acceptInsecureCerts`
is true.
https://www.w3.org/TR/webdriver2/#capabilities

For example, the tests in web-platform-tests use self-signed
certificates to start an http server.
Support for acceptInsecureCerts would be helpful to run those tests
over https.

* Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::startAutomationSession):
* Source/WebDriver/socket/SessionHostSocket.cpp:
(WebDriver::SessionHost::startAutomationSession):
* Source/WebKit/UIProcess/win/AutomationClientWin.cpp:
(WebKit::AutomationSessionClient::AutomationSessionClient):
(WebKit::AutomationSessionClient::didReceiveAuthenticationChallenge):
(WebKit::AutomationSessionClient::requestNewPageWithOptions):
(WebKit::AutomationClient::requestAutomationSession):
* Source/WebKit/UIProcess/win/AutomationClientWin.h:

Canonical link: https://commits.webkit.org/287707@main
@webkit-commit-queue
Copy link
Collaborator

Committed 287707@main (fe03aff): https://commits.webkit.org/287707@main

Reviewed commits have been landed. Closing PR #37764 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fe03aff into WebKit:main Dec 12, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments