[WebDriver][socket] support capabilites.acceptInsecureCerts#37764
[WebDriver][socket] support capabilites.acceptInsecureCerts#37764webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
|
EWS run on previous version of this PR (hash 2dccebb) Details |
Is this before this change or after this change? |
Thank you for your advice. |
2dccebb to
f01be4e
Compare
|
EWS run on current version of this PR (hash f01be4e) Details |
https://bugs.webkit.org/show_bug.cgi?id=284440 Reviewed by Fujii Hironori. Before this change, win port WebDriver does not check the capabilities. The W3C spec defines that self-signed or invalid certificates are implicitly trusted if the value of `capabilities.acceptInsecureCerts` is true. https://www.w3.org/TR/webdriver2/#capabilities For example, the tests in web-platform-tests use self-signed certificates to start an http server. Support for acceptInsecureCerts would be helpful to run those tests over https. * Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp: (Inspector::RemoteInspector::startAutomationSession): * Source/WebDriver/socket/SessionHostSocket.cpp: (WebDriver::SessionHost::startAutomationSession): * Source/WebKit/UIProcess/win/AutomationClientWin.cpp: (WebKit::AutomationSessionClient::AutomationSessionClient): (WebKit::AutomationSessionClient::didReceiveAuthenticationChallenge): (WebKit::AutomationSessionClient::requestNewPageWithOptions): (WebKit::AutomationClient::requestAutomationSession): * Source/WebKit/UIProcess/win/AutomationClientWin.h: Canonical link: https://commits.webkit.org/287707@main
f01be4e to
fe03aff
Compare
|
Committed 287707@main (fe03aff): https://commits.webkit.org/287707@main Reviewed commits have been landed. Closing PR #37764 and removing active labels. |
fe03aff
f01be4e
🛠 ios🛠 wpe🛠 win🛠 mac-AS-debug🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-cairo🛠 🧪 jsc🧪 api-ios🧪 mac-wk2🛠 gtk🛠 vision🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 vision-sim🧪 mac-wk2-stress🧪 api-gtk🧪 mac-intel-wk2🛠 tv🛠 mac-safer-cpp🧪 jsc-armv7-tests🛠 tv-sim🛠 watch🛠 watch-sim