REGRESSION(287835@main): [CoordinatedGraphics] Wrong layer is scrolled sometimes #38064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash d2e6389) |
carlosgcampos
added
the
Platform
webkit-ews-buildbot
added
the
merging-blocked
carlosgcampos
removed
the
merging-blocked
carlosgcampos
force-pushed
the
coord-graphics-async-scrolling-layer-at-point-fix
branch
from
d2e6389 to
1fd0ea5
Compare
|
EWS run on current version of this PR (hash 1fd0ea5)
|
carlosgcampos
added
the
unsafe-merge-queue
…d sometimes https://bugs.webkit.org/show_bug.cgi?id=284805 Reviewed by Alejandro G. Castro. I made a mistake in 287835@main in the point transformation when collecting scrolling layers for a given point, causing the wrong layer to be returned. We should use the parent bounds origin instead of the child one. * Source/WebCore/page/scrolling/coordinated/ScrollingTreeCoordinated.cpp: (WebCore::collectDescendantLayersAtPoint): Canonical link: https://commits.webkit.org/287935@main
webkit-commit-queue
force-pushed
the
coord-graphics-async-scrolling-layer-at-point-fix
branch
from
1fd0ea5 to
66b8578
Compare
|
Committed 287935@main (66b8578): https://commits.webkit.org/287935@main Reviewed commits have been landed. Closing PR #38064 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
carlosgcampos
deleted the
coord-graphics-async-scrolling-layer-at-point-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
66b8578
1fd0ea5
🛠 ios🛠 wpe🛠 win🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-wk2🛠 gtk🛠 vision🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 vision-sim🧪 mac-wk2-stress🧪 api-gtk🧪 mac-intel-wk2🛠 tv🛠 mac-safer-cpp🛠 tv-sim🛠 watch🛠 watch-sim