AX: Rename AXPropertyName to AXProperty#38324
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Dec 23, 2024
Merged
AX: Rename AXPropertyName to AXProperty#38324webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on current version of this PR (hash 49c6f66) Details |
webkit-ews-buildbot
added
the
merging-blocked
fleizach
approved these changes
Dec 23, 2024
twilco
added
merge-queue
https://bugs.webkit.org/show_bug.cgi?id=285083 rdar://141912978 Reviewed by Chris Fleizach. The "Name" suffix in AXPropertyName doesn't add much value, so changing it to AXProperty makes our code more concise. * Source/WebCore/accessibility/AXLogger.cpp: (WebCore::operator<<): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::onEventListenerAdded): (WebCore::AXObjectCache::onEventListenerRemoved): (WebCore::AXObjectCache::onRemoteFrameInitialized): (WebCore::AXObjectCache::onInertOrVisibilityChange): (WebCore::AXObjectCache::onStyleChange): (WebCore::AXObjectCache::handleAttributeChange): (WebCore::AXObjectCache::performDeferredCacheUpdate): (WebCore::AXObjectCache::updateIsolatedTree): (WebCore::AXObjectCache::updateIsolatedTree const): * Source/WebCore/accessibility/AXObjectCache.h: * Source/WebCore/accessibility/cocoa/AXCoreObjectCocoa.mm: (WebCore::AXCoreObject::createAttributedString const): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::initializeProperties): (WebCore::AXIsolatedObject::setMathscripts): (WebCore::AXIsolatedObject::setObjectProperty): (WebCore::AXIsolatedObject::setObjectVectorProperty): (WebCore::AXIsolatedObject::setProperty): (WebCore::AXIsolatedObject::selectedChildren): (WebCore::AXIsolatedObject::cellForColumnAndRow): (WebCore::AXIsolatedObject::accessibilityText const): (WebCore::AXIsolatedObject::mathPrescripts): (WebCore::AXIsolatedObject::mathPostscripts): (WebCore::AXIsolatedObject::mathRadicand): (WebCore::AXIsolatedObject::scrollBar): (WebCore::AXIsolatedObject::colorValue const): (WebCore::AXIsolatedObject::intPointAttributeValue const): (WebCore::AXIsolatedObject::objectAttributeValue const): (WebCore::AXIsolatedObject::rectAttributeValue const): (WebCore::AXIsolatedObject::vectorAttributeValue const): (WebCore::AXIsolatedObject::optionSetAttributeValue const): (WebCore::AXIsolatedObject::indexRangePairAttributeValue const): (WebCore::AXIsolatedObject::optionalAttributeValue const): (WebCore::AXIsolatedObject::uint64AttributeValue const): (WebCore::AXIsolatedObject::urlAttributeValue const): (WebCore::AXIsolatedObject::pathAttributeValue const): (WebCore::AXIsolatedObject::colorAttributeValue const): (WebCore::AXIsolatedObject::floatAttributeValue const): (WebCore::AXIsolatedObject::doubleAttributeValue const): (WebCore::AXIsolatedObject::unsignedAttributeValue const): (WebCore::AXIsolatedObject::boolAttributeValue const): (WebCore::AXIsolatedObject::stringAttributeValue const): (WebCore::AXIsolatedObject::stringAttributeValueNullIfMissing const): (WebCore::AXIsolatedObject::intAttributeValue const): (WebCore::AXIsolatedObject::textRuns const): (WebCore::AXIsolatedObject::getOrRetrievePropertyValue): (WebCore::AXIsolatedObject::fillChildrenVectorForProperty const): (WebCore::AXIsolatedObject::remoteFrameOffset const): (WebCore::AXIsolatedObject::screenRelativePosition const): (WebCore::AXIsolatedObject::relativeFrame const): (WebCore::AXIsolatedObject::insertionPointLineNumber const): (WebCore::AXIsolatedObject::identifierAttribute const): (WebCore::AXIsolatedObject::isPressed const): (WebCore::AXIsolatedObject::hasSameFontColor): (WebCore::AXIsolatedObject::textInputMarkedTextMarkerRange const): (WebCore::AXIsolatedObject::titleAttributeValue const): (WebCore::AXIsolatedObject::stringValue const): (WebCore::AXIsolatedObject::ancestorFlags const): (WebCore::AXIsolatedObject::innerHTML const): (WebCore::AXIsolatedObject::outerHTML const): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h: (WebCore::AXIsolatedObject::propertyValue const): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::createEmptyContent): (WebCore::AXIsolatedTree::reportLoadingProgress): (WebCore::AXIsolatedTree::objectChangedIgnoredState): (WebCore::AXIsolatedTree::updatePropertiesForSelfAndDescendants): (WebCore::AXIsolatedTree::updateNodeProperties): (WebCore::AXIsolatedTree::updateDependentProperties): (WebCore::AXIsolatedTree::updateFrame): (WebCore::AXIsolatedTree::updateRootScreenRelativePosition): (WebCore::AXIsolatedTree::removeNode): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.h: (WebCore::NodeUpdateOptions::NodeUpdateOptions): (WebCore::AXIsolatedTree::updateNodeProperty): (WebCore::AXIsolatedTree::updateNodeProperties): (WebCore::AXIsolatedTree::objectBecameIgnored): * Source/WebCore/accessibility/isolatedtree/mac/AXIsolatedObjectMac.mm: (WebCore::AXIsolatedObject::initializePlatformProperties): (WebCore::AXIsolatedObject::stylesForAttributedString const): (WebCore::AXIsolatedObject::textContent const): (WebCore::AXIsolatedObject::platformStringValue const): (WebCore::AXIsolatedObject::textLength const): (WebCore::AXIsolatedObject::remoteFramePlatformElement const): (WebCore::AXIsolatedObject::attributedStringForTextMarkerRange const): (WebCore::AXIsolatedObject::setPreventKeyboardDOMEventDispatch): (WebCore::AXIsolatedObject::setCaretBrowsingEnabled): Canonical link: https://commits.webkit.org/288241@main
webkit-commit-queue
force-pushed
the
eng/AX-Rename-AXPropertyName-to-AXProperty
branch
from
49c6f66 to
5592179
Compare
Collaborator
|
Committed 288241@main (5592179): https://commits.webkit.org/288241@main Reviewed commits have been landed. Closing PR #38324 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5592179
49c6f66
🧪 mac-intel-wk2