Skip to content

[Buildstream SDK] Fix openh264 support#38558

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
philn:eng/285418
Jan 7, 2025
Merged

[Buildstream SDK] Fix openh264 support#38558
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
philn:eng/285418

Conversation

@philn
Copy link
Member

@philn philn commented Jan 6, 2025

246abc5

[Buildstream SDK] Fix openh264 support
https://bugs.webkit.org/show_bug.cgi?id=285418

Reviewed by Adrian Perez de Castro.

Remove support for the openh264 extension since we now ship our own build of openh264.

* Tools/buildstream/elements/flatpak/platform.bst:
* Tools/buildstream/elements/flatpak/sdk.bst:
* Tools/buildstream/elements/freedesktop-sdk.bst:
* Tools/buildstream/elements/sdk-platform.bst:
* Tools/buildstream/elements/sdk/libopenh264.bst:

Canonical link: https://commits.webkit.org/288516@main

abc53b7

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ❌ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this Jan 6, 2025
@philn philn added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 6, 2025
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for abc53b7. Live statuses available at the PR page, #38558

@philn philn requested a review from aperezdc January 6, 2025 10:52
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 6, 2025
@philn philn added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jan 7, 2025
https://bugs.webkit.org/show_bug.cgi?id=285418

Reviewed by Adrian Perez de Castro.

Remove support for the openh264 extension since we now ship our own build of openh264.

* Tools/buildstream/elements/flatpak/platform.bst:
* Tools/buildstream/elements/flatpak/sdk.bst:
* Tools/buildstream/elements/freedesktop-sdk.bst:
* Tools/buildstream/elements/sdk-platform.bst:
* Tools/buildstream/elements/sdk/libopenh264.bst:

Canonical link: https://commits.webkit.org/288516@main
@webkit-commit-queue
Copy link
Collaborator

Committed 288516@main (246abc5): https://commits.webkit.org/288516@main

Reviewed commits have been landed. Closing PR #38558 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 246abc5 into WebKit:main Jan 7, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 7, 2025
@philn philn deleted the eng/285418 branch January 7, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants