HTML audio element currentTime property too high when setting srcObject to MediaStream (macOS and iOS)#38633
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 7d5f92e) Details |
jyavenard
approved these changes
Jan 7, 2025
Member
jyavenard
left a comment
jyavenard
left a comment
There was a problem hiding this comment.
r=me with comment addressed.
Member
There was a problem hiding this comment.
Suggested change
| , m_startTime(0, 0, 0) | |
| , m_startTime(MediaTime::invalidTime()) |
youennf
force-pushed
the
eng/HTML-audio-element-currentTime-property-too-high-when-setting-srcObject-to-MediaStream-macOS-and-iOS
branch
from
7d5f92e to
0769bcf
Compare
Collaborator
|
EWS run on current version of this PR (hash 0769bcf) Details |
philn
approved these changes
Jan 7, 2025
webkit-ews-buildbot
added
the
merging-blocked
youennf
added
merge-queue
…ct to MediaStream (macOS and iOS) https://bugs.webkit.org/show_bug.cgi?id=285391 rdar://142465970 Reviewed by Jean-Yves Avenard. We were not initializing m_startTime to an invalid value since MediaPlayerPrivateMediaStreamAVFObjC::play is checking for whether it is valid or not. We initialize m_startTime to an invalid value so that it can be correctly initialized in MediaPlayerPrivateMediaStreamAVFObjC::play. Covered by updated test. * LayoutTests/fast/mediastream/media-element-current-time.html: * Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::MediaPlayerPrivateMediaStreamAVFObjC): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): Canonical link: https://commits.webkit.org/288519@main
webkit-commit-queue
force-pushed
the
eng/HTML-audio-element-currentTime-property-too-high-when-setting-srcObject-to-MediaStream-macOS-and-iOS
branch
from
0769bcf to
8194ca4
Compare
Collaborator
|
Committed 288519@main (8194ca4): https://commits.webkit.org/288519@main Reviewed commits have been landed. Closing PR #38633 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
8194ca4
0769bcf
🧪 api-ios🛠 mac-safer-cpp