Skip to content

[GTK][WPE] Add missing includes to WebChromeClient #38935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Jan 14, 2025
Merged

[GTK][WPE] Add missing includes to WebChromeClient #38935

webkit-commit-queue merged 1 commit into from
Jan 14, 2025

Conversation

@zhani
Copy link
Contributor

@zhani zhani commented Jan 13, 2025 •
edited by webkit-early-warning-system
Loading

17c3c12

[GTK][WPE] Add missing includes to WebChromeClient
https://bugs.webkit.org/show_bug.cgi?id=285845

Reviewed by Michael Catanzaro.

The WebChromeClient class was missing some required headers.
While most common compilation flag combinations indirectly
include the necessary headers through other files, certain
combinations can lead to missing includes. This patch explicitly
adds the required headers to ensure compatibility across all compile
flag configurations.

* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:

Canonical link: https://commits.webkit.org/288841@main

58f6696

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zhani zhani requested a review from cdumez as a code owner January 13, 2025 14:42
@zhani zhani requested review from carlosgcampos and removed request for cdumez January 13, 2025 14:42
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 13, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 9e3afeb)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zhani zhani mentioned this pull request Jan 13, 2025
Merged
@zhani zhani force-pushed the fix_missing_includes branch from 9e3afeb to eac0053 Compare January 13, 2025 14:48
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 13, 2025 •
edited
Loading

EWS run on previous version of this PR (hash eac0053)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zhani zhani added request-merge-queue Request a pull request to be added to merge-queue once ready and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Jan 13, 2025
@zhani zhani self-assigned this Jan 13, 2025
@zhani zhani added the request-merge-queue Request a pull request to be added to merge-queue once ready label Jan 13, 2025
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Jan 13, 2025
@zhani zhani force-pushed the fix_missing_includes branch from eac0053 to 58f6696 Compare January 14, 2025 05:02
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 14, 2025 •
edited
Loading

EWS run on current version of this PR (hash 58f6696)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@zhani zhani added request-merge-queue Request a pull request to be added to merge-queue once ready and removed merging-blocked Applied to prevent a change from being merged labels Jan 14, 2025
@zhani zhani mentioned this pull request Jan 14, 2025
Open
@aperezdc aperezdc added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 14, 2025
@zhani @aperezdc
[GTK][WPE] Add missing includes to WebChromeClient
17c3c12 
https://bugs.webkit.org/show_bug.cgi?id=285845

Reviewed by Michael Catanzaro.

The WebChromeClient class was missing some required headers.
While most common compilation flag combinations indirectly
include the necessary headers through other files, certain
combinations can lead to missing includes. This patch explicitly
adds the required headers to ensure compatibility across all compile
flag configurations.

* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:

Canonical link: https://commits.webkit.org/288841@main
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jan 14, 2025

Committed 288841@main (17c3c12): https://commits.webkit.org/288841@main

Reviewed commits have been landed. Closing PR #38935 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 17c3c12 into WebKit:main Jan 14, 2025
@webkit-commit-queue webkit-commit-queue removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing request-merge-queue Request a pull request to be added to merge-queue once ready labels Jan 14, 2025
@zhani zhani deleted the fix_missing_includes branch January 14, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcatanzaro mcatanzaro mcatanzaro approved these changes

@carlosgcampos carlosgcampos Awaiting requested review from carlosgcampos

Assignees

@zhani zhani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhani @webkit-early-warning-system @webkit-commit-queue @mcatanzaro @aperezdc @webkit-ews-buildbot