Skip to content

Conversation

@justinmichaud
Copy link
Contributor

@justinmichaud justinmichaud commented Apr 26, 2022

024fe2f

[PGO] Allow collecting other kinds of pgo profiles.
https://bugs.webkit.org/show_bug.cgi?id=239776

Reviewed by Saam Barati.

Update the way we collect PGO profiles to use LLVM's file handling, because
it really seems to care about that. This allowws us to try out other kinds
of profile generation, like the IR-based -fcs-profile-generate.

* Source/WTF/wtf/GenerateProfiles.h:
(WTF::registerProfileGenerationCallback):

Canonical link: https://commits.webkit.org/250064@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@293544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@justinmichaud justinmichaud self-assigned this Apr 26, 2022
@justinmichaud justinmichaud added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Apr 26, 2022
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this comment a bit more descriptive:
"If we export this symbol, LLVM won't run the static initializers for profiling."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can use makeString

@justinmichaud justinmichaud force-pushed the eng/PGO-Allow-collecting-other-kinds-of-pgo-profiles branch 5 times, most recently from b97f0c7 to 6460953 Compare April 27, 2022 01:24
@justinmichaud
Copy link
Contributor Author

I have confirmed this works with the existing AST-based profiles, merging.

@justinmichaud justinmichaud added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Apr 27, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/PGO-Allow-collecting-other-kinds-of-pgo-profiles branch from 6460953 to 024fe2f Compare April 27, 2022 23:37
@webkit-early-warning-system webkit-early-warning-system merged commit 024fe2f into WebKit:main Apr 27, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r293544 (250064@main): https://commits.webkit.org/250064@main

Reviewed commits have been landed. Closing PR #391 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label Apr 27, 2022
@justinmichaud justinmichaud deleted the eng/PGO-Allow-collecting-other-kinds-of-pgo-profiles branch April 29, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants