Skip to content

Avoid crashing when a client calls WKPageGetSourceForFrame with a frame that no longer exists#39139

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
charliewolfe:eng/Avoid-crashing-when-a-client-calls-WKPageGetSourceForFrame-with-a-frame-that-no-longer-exists
Jan 16, 2025
Merged

Avoid crashing when a client calls WKPageGetSourceForFrame with a frame that no longer exists#39139
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
charliewolfe:eng/Avoid-crashing-when-a-client-calls-WKPageGetSourceForFrame-with-a-frame-that-no-longer-exists

Conversation

@charliewolfe
Copy link
Copy Markdown
Member

@charliewolfe charliewolfe commented Jan 16, 2025

@charliewolfe charliewolfe requested a review from cdumez as a code owner January 16, 2025 19:29
@charliewolfe charliewolfe self-assigned this Jan 16, 2025
@charliewolfe charliewolfe added the WebKit API For issues and bugs in the Web Kit public embedding APIs label Jan 16, 2025
@webkit-early-warning-system
Copy link
Copy Markdown
Collaborator

Starting EWS tests for 863678c. Live statuses available at the PR page, #39139

@charliewolfe charliewolfe added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 16, 2025
…rame that no longer exists

https://bugs.webkit.org/show_bug.cgi?id=286082
rdar://134510049

Reviewed by Pascoe.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getSourceForFrame):

Canonical link: https://commits.webkit.org/289018@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Avoid-crashing-when-a-client-calls-WKPageGetSourceForFrame-with-a-frame-that-no-longer-exists branch from 863678c to 338f89d Compare January 16, 2025 19:52
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 289018@main (338f89d): https://commits.webkit.org/289018@main

Reviewed commits have been landed. Closing PR #39139 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 338f89d into WebKit:main Jan 16, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit API For issues and bugs in the Web Kit public embedding APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants