Skip to content

Reduce use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in WebCore/platform/audio/cocoa/ #39235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Jan 18, 2025
Merged

Reduce use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in WebCore/platform/audio/cocoa/ #39235

webkit-commit-queue merged 1 commit into from
Jan 18, 2025

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Jan 18, 2025 •
edited by webkit-early-warning-system
Loading

b973f84

Reduce use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in WebCore/platform/audio/cocoa/
https://bugs.webkit.org/show_bug.cgi?id=286191

Reviewed by Darin Adler.

* Source/WebCore/platform/audio/cocoa/AudioSampleBufferConverter.mm:
(WebCore::AudioSampleBufferConverter::provideSourceDataNumOutputPackets):
(WebCore::AudioSampleBufferConverter::processSampleBuffers):
* Source/WebCore/platform/audio/cocoa/PlatformRawAudioDataCocoa.cpp:
(WebCore::PlatformRawAudioData::create):

Canonical link: https://commits.webkit.org/289112@main

d3949af

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Jan 18, 2025
@cdumez cdumez added the Media Bugs related to the HTML 5 Media elements. label Jan 18, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 18, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 5901c1c)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ❌ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🧪 api-wpe
loading 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
✅ 🛠 vision-sim ❌ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ❌ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv   🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez force-pushed the 286191_AudioSampleBufferConverter_safe_buffers branch from 5901c1c to d3949af Compare January 18, 2025 04:34
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 18, 2025 •
edited
Loading

EWS run on current version of this PR (hash d3949af)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez marked this pull request as ready for review January 18, 2025 06:07
@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 18, 2025
@cdumez
Reduce use of WTF_ALLOW_UNSAFE_BUFFER_USAGE in WebCore/platform/audio…
b973f84 
…/cocoa/

https://bugs.webkit.org/show_bug.cgi?id=286191

Reviewed by Darin Adler.

* Source/WebCore/platform/audio/cocoa/AudioSampleBufferConverter.mm:
(WebCore::AudioSampleBufferConverter::provideSourceDataNumOutputPackets):
(WebCore::AudioSampleBufferConverter::processSampleBuffers):
* Source/WebCore/platform/audio/cocoa/PlatformRawAudioDataCocoa.cpp:
(WebCore::PlatformRawAudioData::create):

Canonical link: https://commits.webkit.org/289112@main
@webkit-commit-queue webkit-commit-queue force-pushed the 286191_AudioSampleBufferConverter_safe_buffers branch from d3949af to b973f84 Compare January 18, 2025 18:32
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jan 18, 2025

Committed 289112@main (b973f84): https://commits.webkit.org/289112@main

Reviewed commits have been landed. Closing PR #39235 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b973f84 into WebKit:main Jan 18, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darinadler darinadler darinadler approved these changes

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

@ddkilzer ddkilzer Awaiting requested review from ddkilzer

@rniwa rniwa Awaiting requested review from rniwa

Assignees

@cdumez cdumez

Labels

Media Bugs related to the HTML 5 Media elements.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler