-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[libpas] Replace printf calls with pas_log #39498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
dhecht:eng/libpas-Replace-printf-calls-with-pas_log
Jan 24, 2025
Merged
[libpas] Replace printf calls with pas_log #39498
webkit-commit-queue
merged 1 commit into
WebKit:main
from
dhecht:eng/libpas-Replace-printf-calls-with-pas_log
Jan 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Collaborator
|
EWS run on previous version of this PR (hash cb4121c) Details |
kmiller68
approved these changes
Jan 24, 2025
cb4121c to
d3494f1
Compare
Collaborator
|
EWS run on current version of this PR (hash d3494f1) Details |
https://bugs.webkit.org/show_bug.cgi?id=286478 rdar://143571022 Reviewed by Keith Miller. pas_log is preferred because it synchronizes between threads and doesn't buffer. * Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h: (pas_generic_large_free_heap_try_allocate): * Source/bmalloc/libpas/src/libpas/pas_large_free_heap_deferred_commit_log.c: (commit): * Source/bmalloc/libpas/src/libpas/pas_large_heap.c: (allocate_impl): * Source/bmalloc/libpas/src/libpas/pas_large_heap_physical_page_sharing_cache.c: (large_aligned_allocator): * Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c: (pas_probabilistic_guard_malloc_allocate): (pas_probabilistic_guard_malloc_deallocate): (pas_probabilistic_guard_malloc_check_exists): (pas_probabilistic_guard_malloc_return_as_large_map_entry): (pas_probabilistic_guard_malloc_debug_info): * Source/bmalloc/libpas/src/libpas/pas_scavenger.c: (timed_wait): (scavenger_thread_main): (pas_scavenger_notify_eligibility_if_needed): * Source/bmalloc/libpas/src/libpas/pas_simple_free_heap_helpers.c: (pas_simple_free_heap_helpers_try_allocate_with_manual_alignment): (pas_simple_free_heap_helpers_deallocate): * Source/bmalloc/libpas/src/libpas/pas_simple_large_free_heap.c: (fix_free_list_if_necessary): (pas_simple_large_free_heap_try_allocate): (pas_simple_large_free_heap_deallocate): * Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c: (allocate_cache): (pas_thread_local_cache_get_local_allocator_slow): (suspend): Canonical link: https://commits.webkit.org/289353@main
d3494f1 to
0db021d
Compare
Collaborator
|
Committed 289353@main (0db021d): https://commits.webkit.org/289353@main Reviewed commits have been landed. Closing PR #39498 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 wpe-cairo
🧪 mac-wk2
0db021d
d3494f1
🛠 wpe🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🛠 wpe-cairo🛠 🧪 jsc🧪 api-ios🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 vision-wk2🛠 playstation🧪 jsc-armv7-tests🛠 watch