Skip to content

Conversation

@dhecht
Copy link
Contributor

@dhecht dhecht commented Jan 24, 2025

0db021d

[libpas] Replace printf calls with pas_log
https://bugs.webkit.org/show_bug.cgi?id=286478
rdar://143571022

Reviewed by Keith Miller.

pas_log is preferred because it synchronizes between threads and
doesn't buffer.

* Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h:
(pas_generic_large_free_heap_try_allocate):
* Source/bmalloc/libpas/src/libpas/pas_large_free_heap_deferred_commit_log.c:
(commit):
* Source/bmalloc/libpas/src/libpas/pas_large_heap.c:
(allocate_impl):
* Source/bmalloc/libpas/src/libpas/pas_large_heap_physical_page_sharing_cache.c:
(large_aligned_allocator):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_allocate):
(pas_probabilistic_guard_malloc_deallocate):
(pas_probabilistic_guard_malloc_check_exists):
(pas_probabilistic_guard_malloc_return_as_large_map_entry):
(pas_probabilistic_guard_malloc_debug_info):
* Source/bmalloc/libpas/src/libpas/pas_scavenger.c:
(timed_wait):
(scavenger_thread_main):
(pas_scavenger_notify_eligibility_if_needed):
* Source/bmalloc/libpas/src/libpas/pas_simple_free_heap_helpers.c:
(pas_simple_free_heap_helpers_try_allocate_with_manual_alignment):
(pas_simple_free_heap_helpers_deallocate):
* Source/bmalloc/libpas/src/libpas/pas_simple_large_free_heap.c:
(fix_free_list_if_necessary):
(pas_simple_large_free_heap_try_allocate):
(pas_simple_large_free_heap_deallocate):
* Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c:
(allocate_cache):
(pas_thread_local_cache_get_local_allocator_slow):
(suspend):

Canonical link: https://commits.webkit.org/289353@main

d3494f1

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac 🛠 wpe 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 🧪 win-tests
✅ 🧪 webkitperl 🧪 ios-wk2 🧪 api-mac 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 🛠 wpe-cairo
🛠 🧪 jsc 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 tv ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim 🧪 jsc-armv7-tests
🛠 watch
✅ 🛠 watch-sim

@dhecht dhecht requested a review from Constellation as a code owner January 24, 2025 16:25
@dhecht dhecht self-assigned this Jan 24, 2025
@dhecht dhecht added the bmalloc For bugs in bmalloc label Jan 24, 2025
@webkit-early-warning-system
Copy link
Collaborator

Starting EWS tests for cb4121c. Live statuses available at the PR page, #39498

@dhecht dhecht added the merge-queue Applied to send a pull request to merge-queue label Jan 24, 2025
@webkit-ews-buildbot webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed merge-queue Applied to send a pull request to merge-queue labels Jan 24, 2025
@dhecht dhecht removed the merging-blocked Applied to prevent a change from being merged label Jan 24, 2025
@dhecht dhecht force-pushed the eng/libpas-Replace-printf-calls-with-pas_log branch from cb4121c to d3494f1 Compare January 24, 2025 17:13
@dhecht dhecht added the merge-queue Applied to send a pull request to merge-queue label Jan 24, 2025
https://bugs.webkit.org/show_bug.cgi?id=286478
rdar://143571022

Reviewed by Keith Miller.

pas_log is preferred because it synchronizes between threads and
doesn't buffer.

* Source/bmalloc/libpas/src/libpas/pas_generic_large_free_heap.h:
(pas_generic_large_free_heap_try_allocate):
* Source/bmalloc/libpas/src/libpas/pas_large_free_heap_deferred_commit_log.c:
(commit):
* Source/bmalloc/libpas/src/libpas/pas_large_heap.c:
(allocate_impl):
* Source/bmalloc/libpas/src/libpas/pas_large_heap_physical_page_sharing_cache.c:
(large_aligned_allocator):
* Source/bmalloc/libpas/src/libpas/pas_probabilistic_guard_malloc_allocator.c:
(pas_probabilistic_guard_malloc_allocate):
(pas_probabilistic_guard_malloc_deallocate):
(pas_probabilistic_guard_malloc_check_exists):
(pas_probabilistic_guard_malloc_return_as_large_map_entry):
(pas_probabilistic_guard_malloc_debug_info):
* Source/bmalloc/libpas/src/libpas/pas_scavenger.c:
(timed_wait):
(scavenger_thread_main):
(pas_scavenger_notify_eligibility_if_needed):
* Source/bmalloc/libpas/src/libpas/pas_simple_free_heap_helpers.c:
(pas_simple_free_heap_helpers_try_allocate_with_manual_alignment):
(pas_simple_free_heap_helpers_deallocate):
* Source/bmalloc/libpas/src/libpas/pas_simple_large_free_heap.c:
(fix_free_list_if_necessary):
(pas_simple_large_free_heap_try_allocate):
(pas_simple_large_free_heap_deallocate):
* Source/bmalloc/libpas/src/libpas/pas_thread_local_cache.c:
(allocate_cache):
(pas_thread_local_cache_get_local_allocator_slow):
(suspend):

Canonical link: https://commits.webkit.org/289353@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/libpas-Replace-printf-calls-with-pas_log branch from d3494f1 to 0db021d Compare January 24, 2025 17:46
@webkit-commit-queue
Copy link
Collaborator

Committed 289353@main (0db021d): https://commits.webkit.org/289353@main

Reviewed commits have been landed. Closing PR #39498 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0db021d into WebKit:main Jan 24, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bmalloc For bugs in bmalloc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants