[Win Skia] FontCacheSkiaWin.cpp: error: no viable conversion from 'span<const char>' to 'const span<const LChar>' #39676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujii
added
the
New Bugs
Collaborator
|
EWS run on current version of this PR (hash 7e6378b) Details |
fujii
added
the
unsafe-merge-queue
…an<const char>' to 'const span<const LChar>' https://bugs.webkit.org/show_bug.cgi?id=286670 Unreviewed build fix for Windows Skia port. <https://commits.webkit.org/289290@main> changed ""_span operator to return `span<const char>`. * Source/WebCore/platform/graphics/win/FontCacheSkiaWin.cpp: (WebCore::FontCache::createDWriteFactory): Canonical link: https://commits.webkit.org/289487@main
webkit-commit-queue
force-pushed
the
eng/Win-Skia-FontCacheSkiaWin-cpp-error-no-viable-conversion-from-span-const-char-to-const-span-const-LChar
branch
from
7e6378b to
0420fc0
Compare
Collaborator
|
Committed 289487@main (0420fc0): https://commits.webkit.org/289487@main Reviewed commits have been landed. Closing PR #39676 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
fujii
deleted the
eng/Win-Skia-FontCacheSkiaWin-cpp-error-no-viable-conversion-from-span-const-char-to-const-span-const-LChar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0420fc0
7e6378b
🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-cairo🧪 api-ios🧪 mac-wk2🛠 gtk🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 mac-wk2-stress🧪 api-gtk🧪 vision-wk2🧪 mac-intel-wk2🛠 playstation🛠 mac-safer-cpp🛠 watch