Skip to content

Remove shouldRelaxThirdPartyCookieBlocking from SubscribeToCookieChangeNotifications #39803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Jan 31, 2025
Merged

Remove shouldRelaxThirdPartyCookieBlocking from SubscribeToCookieChangeNotifications #39803

webkit-commit-queue merged 1 commit into from
Jan 31, 2025

Conversation

@charliewolfe
Copy link
Member

@charliewolfe charliewolfe commented Jan 31, 2025 •
edited by webkit-early-warning-system
Loading

fa93b6c

Remove `shouldRelaxThirdPartyCookieBlocking` from `SubscribeToCookieChangeNotifications`
https://bugs.webkit.org/show_bug.cgi?id=286792
rdar://143938310

Reviewed by Sihui Liu.

To match changes in 289591@main.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::subscribeToCookieChangeNotifications):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp:
(WebKit::WebCookieCache::cookiesForDOM):
* Source/WebKit/WebProcess/WebPage/WebCookieCache.h:
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::WebCookieJar::cookies const):
(WebKit::WebCookieJar::addChangeListenerWithAccess):
(WebKit::WebCookieJar::addChangeListener):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.h:

Canonical link: https://commits.webkit.org/289619@main

42fb30a

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@charliewolfe charliewolfe requested a review from cdumez as a code owner January 31, 2025 05:26
@charliewolfe charliewolfe self-assigned this Jan 31, 2025
@charliewolfe charliewolfe added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Jan 31, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Jan 31, 2025 •
edited
Loading

EWS run on current version of this PR (hash 42fb30a)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@charliewolfe charliewolfe added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 31, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-shouldRelaxThirdPartyCookieBlocking-from-SubscribeToCookieChangeNotifications branch 2 times, most recently from 0c69124 to bc35f5a Compare January 31, 2025 18:48
@charliewolfe
Remove shouldRelaxThirdPartyCookieBlocking from `SubscribeToCookieC…
fa93b6c 
…hangeNotifications`

https://bugs.webkit.org/show_bug.cgi?id=286792
rdar://143938310

Reviewed by Sihui Liu.

To match changes in 289591@main.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::subscribeToCookieChangeNotifications):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/WebProcess/WebPage/WebCookieCache.cpp:
(WebKit::WebCookieCache::cookiesForDOM):
* Source/WebKit/WebProcess/WebPage/WebCookieCache.h:
* Source/WebKit/WebProcess/WebPage/WebCookieJar.cpp:
(WebKit::WebCookieJar::cookies const):
(WebKit::WebCookieJar::addChangeListenerWithAccess):
(WebKit::WebCookieJar::addChangeListener):
* Source/WebKit/WebProcess/WebPage/WebCookieJar.h:

Canonical link: https://commits.webkit.org/289619@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-shouldRelaxThirdPartyCookieBlocking-from-SubscribeToCookieChangeNotifications branch from bc35f5a to fa93b6c Compare January 31, 2025 18:50
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Jan 31, 2025

Committed 289619@main (fa93b6c): https://commits.webkit.org/289619@main

Reviewed commits have been landed. Closing PR #39803 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit fa93b6c into WebKit:main Jan 31, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szewai szewai szewai approved these changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

@RupinMittal RupinMittal Awaiting requested review from RupinMittal

Assignees

@charliewolfe charliewolfe

Labels

WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charliewolfe @webkit-early-warning-system @webkit-commit-queue @szewai