Skip to content

Comments

[Text Wrapping] Add performance tests for text-wrap-style:pretty.#40415

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
yulunwu2:radar143071848_2
Feb 12, 2025
Merged

[Text Wrapping] Add performance tests for text-wrap-style:pretty.#40415
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
yulunwu2:radar143071848_2

Conversation

@yulunwu2
Copy link
Contributor

@yulunwu2 yulunwu2 commented Feb 11, 2025 •
edited by webkit-early-warning-system
Loading

363bbaa

[Text Wrapping] Add performance tests for text-wrap-style:pretty.
https://bugs.webkit.org/show_bug.cgi?id=286171
<rdar://143071848>

Reviewed by Alan Baradlay.

This change adds performance tests for text-wrap-style:pretty and will allow
developers to measure relative performance between text-wrap-styles
as well as performance implications of future development.

Canonical link: https://commits.webkit.org/290287@main

f015f37

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@yulunwu2 yulunwu2 self-assigned this Feb 11, 2025
@yulunwu2 yulunwu2 added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 11, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 11, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 61fa078)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🧪 api-wpe
  🧪 ios-wk2-wpt ⏳ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ⏳ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
✅ 🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
  🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2   🛠 playstation
  🛠 tv
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

nt1m
nt1m reviewed Feb 11, 2025
View reviewed changes
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 11, 2025 •
edited
Loading

EWS run on current version of this PR (hash f015f37)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ❌ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 11, 2025
@alanbaradlay alanbaradlay added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Feb 12, 2025
@yulunwu2 @alanbaradlay
[Text Wrapping] Add performance tests for text-wrap-style:pretty.
363bbaa 
https://bugs.webkit.org/show_bug.cgi?id=286171
<rdar://143071848>

Reviewed by Alan Baradlay.

This change adds performance tests for text-wrap-style:pretty and will allow
developers to measure relative performance between text-wrap-styles
as well as performance implications of future development.

Canonical link: https://commits.webkit.org/290287@main
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Feb 12, 2025

Committed 290287@main (363bbaa): https://commits.webkit.org/290287@main

Reviewed commits have been landed. Closing PR #40415 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 363bbaa into WebKit:main Feb 12, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nt1m nt1m nt1m left review comments

@alanbaradlay alanbaradlay alanbaradlay approved these changes

Assignees

@yulunwu2 yulunwu2

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yulunwu2 @webkit-early-warning-system @webkit-commit-queue @nt1m @alanbaradlay @webkit-ews-buildbot