Remove ProcessSyncDataType::HasFullscreenElement

[achristensen07]

ae35ee5

Remove ProcessSyncDataType::HasFullscreenElement
https://bugs.webkit.org/show_bug.cgi?id=287541
rdar://144667685

Reviewed by Tim Nguyen.

We don't need all site isolation processes to know that the top document has
a fullscreen element.  We just need to check if the fullscreen element in this
process is in the top document when a request comes to exit fullscreen.

* Source/WebCore/dom/Document.cpp:
(WebCore::Document::populateDocumentSyncDataForNewlyConstructedDocument):
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::clearFullscreenFlags):
(WebCore::FullscreenManager::willEnterFullscreen):
(WebCore::FullscreenManager::updatePageFullscreenStatusIfTopDocument): Deleted.
* Source/WebCore/dom/FullscreenManager.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::updateProcessSyncData):
(WebCore::Page::setTopDocumentHasFullscreenElement): Deleted.
(WebCore::Page::topDocumentHasFullscreenElement): Deleted.
* Source/WebCore/page/Page.h:
* Source/WebCore/page/ProcessSyncData.in:
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::requestExitFullScreen):

Canonical link: https://commits.webkit.org/290288@main

ed34119

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	✅ 🛠 wpe-cairo
	🧪 api-ios	🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	🧪 api-gtk
	🧪 vision-wk2	🧪 mac-intel-wk2	✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv	🛠 mac-safer-cpp
	🛠 tv-sim
	🛠 watch
	🛠 watch-sim

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 6116ba9)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	❌ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	❌ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[nt1m]

As much as I'd love getting rid of this code, fullscreen/iframe-fullscreen-system-exit.html seems to be regressing (e.g. https://bugs.webkit.org/show_bug.cgi?id=287309 )

[nt1m]

I'm guessing there's a mismatch between WebFullscreenManager::m_element and FullscreenManager::fullscreenElement(). If I had to guess, it's the same mismatch than between FullscreenManager::fullscreenElement() and FullscreenManager::m_fullscreenElement

[webkit-early-warning-system]

EWS run on previous version of this PR (hash dbe238d)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	✅ 🛠 wpe-cairo
	🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	🧪 api-gtk
	🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	🛠 watch
	✅ 🛠 watch-sim

[nt1m]

LGTM modulo leaving the move to Document.cpp

[nt1m]

Any reason to move this to Document ? Can't we just leave this on FullscreenManager and access it from there? I'd prefer fullscreen logic to be contained.

[webkit-early-warning-system]

EWS run on current version of this PR (hash ed34119)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2	🧪 win-tests
✅ 🧪 webkitperl	🧪 ios-wk2	🧪 api-mac	🧪 api-wpe
	🧪 ios-wk2-wpt	🧪 mac-wk1	✅ 🛠 wpe-cairo
	🧪 api-ios	🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	🧪 mac-AS-debug-wk2	🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	🧪 api-gtk
	🧪 vision-wk2	🧪 mac-intel-wk2	✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv	🛠 mac-safer-cpp
	🛠 tv-sim
	🛠 watch
	🛠 watch-sim

[webkit-commit-queue]

Committed 290288@main (ae35ee5): https://commits.webkit.org/290288@main

Reviewed commits have been landed. Closing PR #40462 and removing active labels.