-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Support <link rel=dns-prefetch> on iOS and remove privacy-invasive DNS prefetching features #40488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
annevk:eng/Support-link-rel-dns-prefetch-on-iOS-and-remove-privacy-invasive-DNS-prefetching-features
Feb 13, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
EWS run on current version of this PR (hash 417f925) Details |
achristensen07
approved these changes
Feb 12, 2025
…S prefetching features https://bugs.webkit.org/show_bug.cgi?id=285744 rdar://144699889 Reviewed by Alex Christensen. This was initially landed as 288915@main and backed out in 288920@main because it was not understood all functionality was enabled for macOS. This commit wants to reland 288915@main as-is, but now with the understanding that this removes privacy-invasive and proprietary DNS prefetching features from macOS, while continuing to support the standardized <link rel=dns-prefetch> and extending that support to iOS and other WebKit ports. * LayoutTests/http/tests/misc/dns-prefetch-control-expected.txt: * LayoutTests/http/tests/misc/dns-prefetch-control.html: * LayoutTests/http/tests/misc/resources/dns-prefetch-control.py: Removed. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/dom/Document.cpp: (WebCore::Document::processMetaHttpEquiv): (WebCore::Document::initDNSPrefetch): Deleted. (WebCore::Document::isDNSPrefetchEnabled const): Deleted. (WebCore::Document::parseDNSPrefetchControlHeader): Deleted. * Source/WebCore/dom/Document.h: * Source/WebCore/html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::attributeChanged): * Source/WebCore/html/LinkRelAttribute.cpp: * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument): * Source/WebCore/loader/LinkLoader.cpp: (WebCore::LinkLoader::loadLink): * Source/WebCore/page/Chrome.cpp: (WebCore::Chrome::mouseDidMoveOverElement): * Source/WebCore/page/Page.cpp: (WebCore::Page::dnsPrefetchingStateChanged): Deleted. * Source/WebCore/page/Page.h: * Source/WebCore/page/SettingsBase.cpp: (WebCore::SettingsBase::dnsPrefetchingEnabledChanged): Deleted. * Source/WebCore/page/SettingsBase.h: * Source/WebCore/platform/network/HTTPHeaderNames.in: * Source/WebCore/platform/network/ResourceResponseBase.cpp: (WebCore::isSafeCrossOriginResponseHeader): * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetDNSPrefetchingEnabled): (WKPreferencesGetDNSPrefetchingEnabled): (WKPreferencesSetRestrictedHTTPResponseAccess): * Source/WebKit/UIProcess/API/C/WKPreferencesRef.h: * Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm: (-[WKPreferences _setDNSPrefetchingEnabled:]): (-[WKPreferences _dnsPrefetchingEnabled]): * Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h: * Source/WebKit/UIProcess/API/glib/WebKitSettings.cpp: (webkit_settings_class_init): (webkit_settings_get_enable_dns_prefetching): (webkit_settings_set_enable_dns_prefetching): * Source/WebKit/UIProcess/API/glib/WebKitSettings.h.in: * Source/WebKit/UIProcess/Extensions/Cocoa/_WKWebExtensionDeclarativeNetRequestRule.mm: (isHeaderNameValid): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::sendTapHighlightForNodeIfNecessary): * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences isDNSPrefetchingEnabled]): (-[WebPreferences setDNSPrefetchingEnabled:]): * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: * Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: (testWebKitSettings): Canonical link: https://commits.webkit.org/290327@main
417f925 to
634cc1e
Compare
Collaborator
|
Committed 290327@main (634cc1e): https://commits.webkit.org/290327@main Reviewed commits have been landed. Closing PR #40488 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WebCore Misc.
For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
634cc1e
417f925