Skip to content

Conversation

@bls1999
Copy link
Contributor

@bls1999 bls1999 commented Feb 19, 2025

a93189b

[webkitpy] Pass udids to available_devices in device_port.py.
https://bugs.webkit.org/show_bug.cgi?id=287925
rdar://145106362

Reviewed by Brianna Fan.

This PR changes device_port.py to pass udids in available_devices as well as
initialize_devices. This is to preserve compatibility with multiple device
manager types.

* Tools/Scripts/webkitpy/port/device_port.py:
(DevicePort.supported_device_types): Add udids to available_devices invocation.
* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.available_devices): Add udids as a parameter.

Canonical link: https://commits.webkit.org/290644@main

aa6337c

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@bls1999 bls1999 self-assigned this Feb 19, 2025
@bls1999 bls1999 added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 19, 2025
@bls1999 bls1999 requested a review from briannafan February 19, 2025 19:06
@bls1999 bls1999 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 19, 2025
https://bugs.webkit.org/show_bug.cgi?id=287925
rdar://145106362

Reviewed by Brianna Fan.

This PR changes device_port.py to pass udids in available_devices as well as
initialize_devices. This is to preserve compatibility with multiple device
manager types.

* Tools/Scripts/webkitpy/port/device_port.py:
(DevicePort.supported_device_types): Add udids to available_devices invocation.
* Tools/Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.available_devices): Add udids as a parameter.

Canonical link: https://commits.webkit.org/290644@main
@webkit-commit-queue
Copy link
Collaborator

Committed 290644@main (a93189b): https://commits.webkit.org/290644@main

Reviewed commits have been landed. Closing PR #40824 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit a93189b into WebKit:main Feb 19, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants