Fix internal visionOS build. #41061
Merged
Fix internal visionOS build. #41061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlrackler
added
the
New Bugs
Collaborator
|
EWS run on previous version of this PR (hash 7119450) Details |
karlrackler
added
the
unsafe-merge-queue
Collaborator
|
Commit message contains (OOPS!) and no valid reviewer found, blocking PR #41061. Details: Build #14387 |
webkit-commit-queue
added
merging-blocked
cdumez
reviewed
Feb 21, 2025
Contributor
There was a problem hiding this comment.
Please fix indentation and use FIXME: (all caps).
Contributor
There was a problem hiding this comment.
Ideally something like:
// FIXME: Stop using `AVAudioSessionCategoryOptionAllowBluetooth` as it is deprecated (rdar://145294046).
7119450 to
59d9a75
Compare
Collaborator
|
EWS run on previous version of this PR (hash 59d9a75) Details |
karlrackler
force-pushed
the
eng/Fix-internal-visionOS-build
branch
from
59d9a75 to
0bd7851
Compare
Collaborator
|
EWS run on current version of this PR (hash 0bd7851) Details |
cdumez
approved these changes
Feb 21, 2025
karlrackler
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=288197 rdar://145293550 Reviewed by Chris Dumez. Fix internal visionOS build. * Source/WebCore/platform/audio/ios/AudioSessionIOS.mm: (WebCore::AudioSessionIOS::setCategory): Canonical link: https://commits.webkit.org/290797@main
webkit-commit-queue
force-pushed
the
eng/Fix-internal-visionOS-build
branch
from
0bd7851 to
e91baab
Compare
Collaborator
|
Committed 290797@main (e91baab): https://commits.webkit.org/290797@main Reviewed commits have been landed. Closing PR #41061 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e91baab
0bd7851
🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-cairo🧪 api-ios🧪 mac-wk2🛠 gtk🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 mac-wk2-stress🧪 api-gtk🧪 vision-wk2🧪 mac-intel-wk2🛠 playstation🛠 mac-safer-cpp