[ResourceMonitor] Add more meaningful release log information part 2.#41142
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 13, 2025
Merged
[ResourceMonitor] Add more meaningful release log information part 2.#41142webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 69d77be) Details |
cdumez
reviewed
Feb 22, 2025
cdumez
requested changes
Mar 10, 2025
Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
Outdated
Show resolved
Hide resolved
69d77be to
395375e
Compare
Collaborator
|
EWS run on previous version of this PR (hash 395375e) Details |
cdumez
reviewed
Mar 11, 2025
LayoutTests/http/tests/security/mixedContent/resources/frame-with-insecure-localhost-image.html
Outdated
Show resolved
Hide resolved
395375e to
f6d5afb
Compare
Collaborator
|
EWS run on previous version of this PR (hash f6d5afb) Details |
cdumez
requested changes
Mar 11, 2025
Contributor
There was a problem hiding this comment.
Definitely not OK to print out a host with PUBLIC_LOG_STRING.
Contributor
There was a problem hiding this comment.
We can use url.host().utf8().data()
Contributor
There was a problem hiding this comment.
Sad to be creating a new String for no good reason now.
Contributor
There was a problem hiding this comment.
We can keep the code as is. It was more efficient.
f6d5afb to
cb014aa
Compare
Collaborator
|
EWS run on current version of this PR (hash cb014aa) Details |
cdumez
approved these changes
Mar 11, 2025
bc603ea to
43eb66e
Compare
https://bugs.webkit.org/show_bug.cgi?id=288174 rdar://145259890 Reviewed by Chris Dumez. Adding new log category and move current release logs to that category. And also add more meaningful information for the record. This is part 2, targeting WebKit. * Source/WebCore/loader/ResourceMonitor.cpp: (WebCore::ResourceMonitor::networkUsageLevel const): * Source/WebCore/loader/ResourceMonitor.h: * Source/WebCore/loader/ResourceMonitorChecker.cpp: (WebCore::ResourceMonitorChecker::checkEligibility): (WebCore::ResourceMonitorChecker::setContentRuleList): (WebCore::ResourceMonitorChecker::finishPendingQueries): (WebCore::ResourceMonitorChecker::setNetworkUsageThreshold): * Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::shouldOffloadIFrameForHost): * Source/WebKit/NetworkProcess/NetworkSession.cpp: (WebKit::NetworkSession::resourceMonitorThrottler): * Source/WebKit/Platform/Logging.h: * Source/WebKit/Platform/cocoa/WebPrivacyHelpers.mm: (WebKit::ResourceMonitorURLsController::prepare): * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformLoadResourceMonitorRuleList): * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::loadOrUpdateResourceMonitorRuleList): * Source/WebKit/WebProcess/Network/WebResourceLoader.cpp: (WebKit::WebResourceLoader::updateBytesTransferredOverNetwork): * Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp: (WebKit::WebLocalFrameLoaderClient::didExceedNetworkUsageThreshold): * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::setResourceMonitorContentRuleList): (WebKit::WebProcess::setResourceMonitorContentRuleListAsync): Canonical link: https://commits.webkit.org/292052@main
43eb66e to
c7af5b9
Compare
Collaborator
|
Committed 292052@main (c7af5b9): https://commits.webkit.org/292052@main Reviewed commits have been landed. Closing PR #41142 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c7af5b9
cb014aa