Skip to content

Annotate more WebXR endpoints #41308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
webkit-commit-queue merged 1 commit into from
Feb 28, 2025
Merged

Annotate more WebXR endpoints #41308

webkit-commit-queue merged 1 commit into from
Feb 28, 2025

Conversation

@darryl-apple
Copy link
Contributor

@darryl-apple darryl-apple commented Feb 25, 2025 •
edited by webkit-early-warning-system
Loading

7318d03

Annotate more WebXR endpoints
https://bugs.webkit.org/show_bug.cgi?id=288508
rdar://problem/145583314

Reviewed by Sihui Liu.

Guard more CoreIPC WebXR endpoints with feature flag

* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:

Canonical link: https://commits.webkit.org/291317@main

30837ca

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@darryl-apple darryl-apple self-assigned this Feb 25, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 25, 2025 •
edited
Loading

EWS run on previous version of this PR (hash d02edd5)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Feb 25, 2025
@darryl-apple darryl-apple requested a review from szewai February 26, 2025 11:32
@szewai
Copy link
Contributor

szewai commented Feb 26, 2025

The commit message format is not right

@darryl-apple darryl-apple removed the merging-blocked Applied to prevent a change from being merged label Feb 27, 2025
@darryl-apple darryl-apple force-pushed the eng/Annotate-more-WebXR-endpoints branch from d02edd5 to 30837ca Compare February 27, 2025 15:39
@darryl-apple darryl-apple added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Feb 27, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Feb 27, 2025 •
edited
Loading

EWS run on current version of this PR (hash 30837ca)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@darryl-apple darryl-apple added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Feb 28, 2025
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Feb 28, 2025
@webkit-ews-buildbot
Copy link
Collaborator

webkit-ews-buildbot commented Feb 28, 2025

Safe-Merge-Queue: Build #50097.

@darryl-apple
Annotate more WebXR endpoints
7318d03 
https://bugs.webkit.org/show_bug.cgi?id=288508
rdar://problem/145583314

Reviewed by Sihui Liu.

Guard more CoreIPC WebXR endpoints with feature flag

* Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.messages.in:

Canonical link: https://commits.webkit.org/291317@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Annotate-more-WebXR-endpoints branch from 30837ca to 7318d03 Compare February 28, 2025 13:31
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented Feb 28, 2025

Committed 291317@main (7318d03): https://commits.webkit.org/291317@main

Reviewed commits have been landed. Closing PR #41308 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7318d03 into WebKit:main Feb 28, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szewai szewai szewai approved these changes

Assignees

@darryl-apple darryl-apple

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@darryl-apple @webkit-early-warning-system @szewai @webkit-ews-buildbot @webkit-commit-queue