Add Mac style menulist-button appearance for Catalyst #41530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilyspiniolas
added
the
New Bugs
Collaborator
|
EWS run on previous version of this PR (hash 04aa14f) Details |
lilyspiniolas
requested review from
aprotyas,
hortont424,
jesxilin,
megangardner,
pxlcoder,
rr-codes and
whsieh
lilyspiniolas
force-pushed
the
eng/145672619
branch
from
04aa14f to
1ac672d
Compare
Collaborator
|
EWS run on previous version of this PR (hash 1ac672d) Details |
pxlcoder
reviewed
Feb 27, 2025
webkit-ews-buildbot
added
the
merging-blocked
lilyspiniolas
removed
the
merging-blocked
lilyspiniolas
force-pushed
the
eng/145672619
branch
from
1ac672d to
f238d57
Compare
Collaborator
|
EWS run on previous version of this PR (hash f238d57) Details
|
lilyspiniolas
force-pushed
the
eng/145672619
branch
from
f238d57 to
99c1b58
Compare
Collaborator
|
EWS run on previous version of this PR (hash 99c1b58) Details |
pxlcoder
reviewed
Feb 28, 2025
Comment on lines
603
to
604
Member
There was a problem hiding this comment.
hmm we've normally been checking the setting in the condition and then return RenderThemeCocoa:: inside.
pxlcoder
approved these changes
Feb 28, 2025
lilyspiniolas
force-pushed
the
eng/145672619
branch
from
99c1b58 to
6f6e004
Compare
Collaborator
|
EWS run on current version of this PR (hash 6f6e004) Details |
lilyspiniolas
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=288733 rdar://145672619 Reviewed by Aditya Keerthi. Allow Catalyst to paint menulist-buttons when using Mac-style controls, and to adjust CSS styles accordingly. Removed a few unused variables from RenderThemeIOS. Updated codepath for focus ring support on Catalyst. * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): * Source/WebCore/rendering/RenderTheme.h: (WebCore::RenderTheme::paintMenuListButton): * Source/WebCore/rendering/cocoa/RenderThemeCocoa.h: * Source/WebCore/rendering/cocoa/RenderThemeCocoa.mm: (WebCore::RenderThemeCocoa::paintMenuListButton): (WebCore::RenderThemeCocoa::supportsFocusRing const): * Source/WebCore/rendering/ios/RenderThemeIOS.mm: (WebCore::applyCommonButtonPaddingToStyle): (WebCore::adjustInputElementButtonStyle): (WebCore::RenderThemeIOS::adjustMenuListButtonStyle const): (WebCore::RenderThemeIOS::paintMenuListButtonDecorations): (WebCore::RenderThemeIOS::supportsFocusRing const): Canonical link: https://commits.webkit.org/291291@main
webkit-commit-queue
force-pushed
the
eng/145672619
branch
from
6f6e004 to
33a5d09
Compare
Collaborator
|
Committed 291291@main (33a5d09): https://commits.webkit.org/291291@main Reviewed commits have been landed. Closing PR #41530 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
33a5d09
6f6e004
🛠 ios🛠 wpe🛠 win🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-cairo🧪 api-ios🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 vision-sim🧪 mac-intel-wk2🛠 playstation🛠 mac-safer-cpp🛠 tv-sim🛠 watch