Skip to content

Conversation

@graouts
Copy link
Contributor

@graouts graouts commented Feb 27, 2025

37f0b2e

[scroll-animations] WPT test `scroll-animations/css/timeline-scope.html` is a failure
https://bugs.webkit.org/show_bug.cgi?id=288755

Reviewed by Dean Jackson.

When a `timeline-scope: none` value is set, we must make sure to unregister all timelines
that were previously created for a name within that scope.

Then, if an animation has its `animation-timeline` set to a value that has not yet resolved
to a scoped name, we must keep it in the list of pending animations such that if we move to
a value other then `timeline-scope: none`, this timeline name may resolve dynamically.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-scope-expected.txt:
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
(WebCore::StyleOriginatedTimelinesController::attachAnimation):
(WebCore::StyleOriginatedTimelinesController::updateNamedTimelineMapForTimelineScope):

Canonical link: https://commits.webkit.org/291303@main

9e0af04

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@graouts graouts self-assigned this Feb 27, 2025
@graouts graouts added the Animations Bugs related to CSS + SVG animations and transitions label Feb 27, 2025
@graouts graouts force-pushed the eng/scroll-animations-WPT-test-scroll-animations-css-timeline-scope-html-is-a-failure branch from 03b9375 to 9e0af04 Compare February 27, 2025 22:31
@graouts graouts added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Feb 28, 2025
…ml` is a failure

https://bugs.webkit.org/show_bug.cgi?id=288755

Reviewed by Dean Jackson.

When a `timeline-scope: none` value is set, we must make sure to unregister all timelines
that were previously created for a name within that scope.

Then, if an animation has its `animation-timeline` set to a value that has not yet resolved
to a scoped name, we must keep it in the list of pending animations such that if we move to
a value other then `timeline-scope: none`, this timeline name may resolve dynamically.

* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/css/timeline-scope-expected.txt:
* Source/WebCore/animation/StyleOriginatedTimelinesController.cpp:
(WebCore::StyleOriginatedTimelinesController::attachAnimation):
(WebCore::StyleOriginatedTimelinesController::updateNamedTimelineMapForTimelineScope):

Canonical link: https://commits.webkit.org/291303@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/scroll-animations-WPT-test-scroll-animations-css-timeline-scope-html-is-a-failure branch from 9e0af04 to 37f0b2e Compare February 28, 2025 06:28
@webkit-commit-queue webkit-commit-queue merged commit 37f0b2e into WebKit:main Feb 28, 2025
@webkit-commit-queue
Copy link
Collaborator

Committed 291303@main (37f0b2e): https://commits.webkit.org/291303@main

Reviewed commits have been landed. Closing PR #41553 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 28, 2025
@graouts graouts deleted the eng/scroll-animations-WPT-test-scroll-animations-css-timeline-scope-html-is-a-failure branch February 28, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Animations Bugs related to CSS + SVG animations and transitions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants