-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Refactor dynamic-range-limit layer-setting code after suppress-HDR notifications #41909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dynamic-range-limit layer-setting code after suppress-HDR notifications #41909
Conversation
|
EWS run on previous version of this PR (hash a869bc4) Details |
a869bc4 to
26f231a
Compare
|
EWS run on previous version of this PR (hash 26f231a) Details |
|
Reconsidering... -> draft for now. |
26f231a to
917c44d
Compare
|
EWS run on previous version of this PR (hash 917c44d) Details |
917c44d to
7027a92
Compare
|
EWS run on previous version of this PR (hash 7027a92) Details |
7027a92 to
3b14102
Compare
|
EWS run on previous version of this PR (hash 3b14102) Details |
3b14102 to
8a479e9
Compare
|
EWS run on current version of this PR (hash 8a479e9) Details |
…tifications https://bugs.webkit.org/show_bug.cgi?id=289152 rdar://146238622 Reviewed by Mike Wyrzykowski. Centralize the dynamic-range-limit to be used when suppressing HDR in videos and other elements. Also directly use the window-did-become/resign-key notification to use as window activity state -- `m_page->isViewWindowActive()` was not actually correct yet. And only update layer properties when the target dynamic range limit has actually changed. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::computePlayerDynamicRangeLimit const): * Source/WebCore/platform/graphics/PlatformDynamicRangeLimit.h: (WebCore::PlatformDynamicRangeLimit::defaultWhenSuppressingHDR): (WebCore::PlatformDynamicRangeLimit::defaultWhenSuppressingHDRInVideos): * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::windowDidBecomeKey): (WebKit::WebViewImpl::windowDidResignKey): (WebKit::WebViewImpl::updateHDRState): (WebKit::WebViewImpl::applicationShouldSuppressHDR): (WebKit::WebViewImpl::applicationShouldAllowHDR): Canonical link: https://commits.webkit.org/292044@main
8a479e9 to
dfab897
Compare
|
Committed 292044@main (dfab897): https://commits.webkit.org/292044@main Reviewed commits have been landed. Closing PR #41909 and removing active labels. |
dfab897
8a479e9