Skip to content

[GStreamer][WebRTC] Move GCC bandwidth estimator closer to transport elements#41914

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
philn:eng/289156
Mar 6, 2025
Merged

[GStreamer][WebRTC] Move GCC bandwidth estimator closer to transport elements#41914
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
philn:eng/289156

Conversation

@philn
Copy link
Copy Markdown
Member

@philn philn commented Mar 5, 2025

dfb39d6

[GStreamer][WebRTC] Move GCC bandwidth estimator closer to transport elements
https://bugs.webkit.org/show_bug.cgi?id=289156

Reviewed by Xabier Rodriguez-Calvar.

By placing the estimator after rtpsession the estimator won't be burdened by its synchronization
requirements.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::initializePipeline):

Canonical link: https://commits.webkit.org/291697@main

1201c58

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@philn philn self-assigned this Mar 5, 2025
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Mar 5, 2025
@philn philn requested a review from calvaris March 5, 2025 11:58
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Mar 6, 2025
…elements

https://bugs.webkit.org/show_bug.cgi?id=289156

Reviewed by Xabier Rodriguez-Calvar.

By placing the estimator after rtpsession the estimator won't be burdened by its synchronization
requirements.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::initializePipeline):

Canonical link: https://commits.webkit.org/291697@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 291697@main (dfb39d6): https://commits.webkit.org/291697@main

Reviewed commits have been landed. Closing PR #41914 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit dfb39d6 into WebKit:main Mar 6, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 6, 2025
@philn philn deleted the eng/289156 branch March 6, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Portability improvements and other general platform improvements not driven directly by site bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants