Address more Safer CPP failures in WebViewImpl.mm#42042
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Mar 7, 2025
Merged
Address more Safer CPP failures in WebViewImpl.mm#42042webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on current version of this PR (hash fece0f3) Details |
charliewolfe
approved these changes
Mar 7, 2025
fece0f3 to
dffa041
Compare
https://bugs.webkit.org/show_bug.cgi?id=289281 Reviewed by Charlie Wolfe. * Source/WebKit/Platform/cocoa/_WKWebViewTextInputNotifications.mm: (-[_WKWebViewTextInputNotifications dictationDidStart]): (-[_WKWebViewTextInputNotifications dictationDidEnd]): (-[_WKWebViewTextInputNotifications dictationDidPause]): (-[_WKWebViewTextInputNotifications dictationDidResume]): * Source/WebKit/UIProcess/mac/CorrectionPanel.mm: (WebKit::CorrectionPanel::recordAutocorrectionResponse): * Source/WebKit/UIProcess/mac/WebViewImpl.h: * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::WebViewImpl): (WebKit::m_flagsChangedEventMonitorTrackingArea): (WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent): (WebKit::WebViewImpl::performDragOperation): (WebKit::WebViewImpl::showWritingTools): (WebKit::WebViewImpl::protectedPage const): Deleted. Canonical link: https://commits.webkit.org/291755@main
dffa041 to
c5057d6
Compare
Collaborator
|
Committed 291755@main (c5057d6): https://commits.webkit.org/291755@main Reviewed commits have been landed. Closing PR #42042 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c5057d6
fece0f3