Skip to content

Address more Safer CPP failures in WebViewImpl.mm#42042

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:289281_WebViewImpl_safer_cpp
Mar 7, 2025
Merged

Address more Safer CPP failures in WebViewImpl.mm#42042
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
cdumez:289281_WebViewImpl_safer_cpp

Conversation

@cdumez
Copy link
Contributor

@cdumez cdumez commented Mar 6, 2025

c5057d6

Address more Safer CPP failures in WebViewImpl.mm
https://bugs.webkit.org/show_bug.cgi?id=289281

Reviewed by Charlie Wolfe.

* Source/WebKit/Platform/cocoa/_WKWebViewTextInputNotifications.mm:
(-[_WKWebViewTextInputNotifications dictationDidStart]):
(-[_WKWebViewTextInputNotifications dictationDidEnd]):
(-[_WKWebViewTextInputNotifications dictationDidPause]):
(-[_WKWebViewTextInputNotifications dictationDidResume]):
* Source/WebKit/UIProcess/mac/CorrectionPanel.mm:
(WebKit::CorrectionPanel::recordAutocorrectionResponse):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::m_flagsChangedEventMonitorTrackingArea):
(WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent):
(WebKit::WebViewImpl::performDragOperation):
(WebKit::WebViewImpl::showWritingTools):
(WebKit::WebViewImpl::protectedPage const): Deleted.

Canonical link: https://commits.webkit.org/291755@main

fece0f3

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Mar 6, 2025
@cdumez cdumez added the WebKit2 Bugs relating to the WebKit2 API layer label Mar 6, 2025
@cdumez cdumez marked this pull request as ready for review March 7, 2025 05:02
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Mar 7, 2025
@webkit-commit-queue webkit-commit-queue force-pushed the 289281_WebViewImpl_safer_cpp branch from fece0f3 to dffa041 Compare March 7, 2025 06:03
https://bugs.webkit.org/show_bug.cgi?id=289281

Reviewed by Charlie Wolfe.

* Source/WebKit/Platform/cocoa/_WKWebViewTextInputNotifications.mm:
(-[_WKWebViewTextInputNotifications dictationDidStart]):
(-[_WKWebViewTextInputNotifications dictationDidEnd]):
(-[_WKWebViewTextInputNotifications dictationDidPause]):
(-[_WKWebViewTextInputNotifications dictationDidResume]):
* Source/WebKit/UIProcess/mac/CorrectionPanel.mm:
(WebKit::CorrectionPanel::recordAutocorrectionResponse):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::m_flagsChangedEventMonitorTrackingArea):
(WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent):
(WebKit::WebViewImpl::performDragOperation):
(WebKit::WebViewImpl::showWritingTools):
(WebKit::WebViewImpl::protectedPage const): Deleted.

Canonical link: https://commits.webkit.org/291755@main
@webkit-commit-queue webkit-commit-queue force-pushed the 289281_WebViewImpl_safer_cpp branch from dffa041 to c5057d6 Compare March 7, 2025 06:05
@webkit-commit-queue
Copy link
Collaborator

Committed 291755@main (c5057d6): https://commits.webkit.org/291755@main

Reviewed commits have been landed. Closing PR #42042 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c5057d6 into WebKit:main Mar 7, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit2 Bugs relating to the WebKit2 API layer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants