[Win] Improvements to run loop timer resolution #42936

iangrunert · 2025-03-24T16:39:23Z

`70d5b92`

[Win] Improvements to run loop timer resolution
https://bugs.webkit.org/show_bug.cgi?id=284823

Reviewed by Yusuke Suzuki.

WM_TIMER has a 10ms resolution, which means we can't hit 60fps on
requestAnimationFrame. By using MsgWaitForMultipleObjectsEx and
maintaining our own timer queue we can get better timer resolution.

* Source/WTF/wtf/RunLoop.h:
* Source/WTF/wtf/win/RunLoopWin.cpp:
(WTF::RunLoop::wndProc):
(WTF::RunLoop::run):
(WTF::RunLoop::msTillNextTimer):
(WTF::RunLoop::fireTimers):
(WTF::RunLoop::cycle):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):

Canonical link: https://commits.webkit.org/292846@main

ea2075e

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	~~🧪 vision-wk2~~	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-03-24T16:41:33Z

EWS run on previous version of this PR (hash 79805fc)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	~~🛠 ios~~	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
✅ 🛠 🧪 jsc	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	~~🛠 vision~~	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	⏳ 🧪 api-gtk
	⏳ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~	✅ 🛠 jsc-armv7
	~~🛠 tv-sim~~		⏳ 🧪 jsc-armv7-tests
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2025-03-24T16:49:13Z

EWS run on previous version of this PR (hash b8a3e2e)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-03-24T21:00:07Z

EWS run on previous version of this PR (hash b9d5665)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 win-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-03-27T21:12:31Z

EWS run on previous version of this PR (hash 9b6d578)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	⏳ 🧪 api-mac	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
~~🛠 🧪 jsc~~	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	~~🛠 vision-sim~~	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	⏳ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
	~~🛠 watch~~
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-03-27T21:22:12Z

EWS run on current version of this PR (hash ea2075e)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	⏳ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	~~🧪 vision-wk2~~	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=284823 Reviewed by Yusuke Suzuki. WM_TIMER has a 10ms resolution, which means we can't hit 60fps on requestAnimationFrame. By using MsgWaitForMultipleObjectsEx and maintaining our own timer queue we can get better timer resolution. * Source/WTF/wtf/RunLoop.h: * Source/WTF/wtf/win/RunLoopWin.cpp: (WTF::RunLoop::wndProc): (WTF::RunLoop::run): (WTF::RunLoop::msTillNextTimer): (WTF::RunLoop::fireTimers): (WTF::RunLoop::cycle): (WTF::RunLoop::TimerBase::timerFired): (WTF::RunLoop::TimerBase::start): (WTF::RunLoop::TimerBase::stop): Canonical link: https://commits.webkit.org/292846@main

webkit-commit-queue · 2025-03-28T19:51:41Z

Committed 292846@main (70d5b92): https://commits.webkit.org/292846@main

Reviewed commits have been landed. Closing PR #42936 and removing active labels.

fujii · 2025-03-28T22:16:06Z

Unfortenately, this change made layout tests crashy. Even though EWS actually catched a crash, but not reported it with a red bubble. I'm going to revert this change temporarily. Will take a look next week.

fujii · 2025-03-29T13:36:04Z

Source/WTF/wtf/win/RunLoopWin.cpp

-            if (m_liveTimers.contains(wParam))
-                timer = std::bit_cast<RunLoop::TimerBase*>(wParam);
-        }
+        timer = std::bit_cast<RunLoop::TimerBase*>(wParam);


timer can be already destroyed here. I fixed it in #43244

iangrunert self-assigned this Mar 24, 2025

iangrunert force-pushed the ig/bug-284823-win-run-loop-improvements branch from 79805fc to b8a3e2e Compare March 24, 2025 16:49

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Mar 24, 2025

Constellation approved these changes Mar 24, 2025

View reviewed changes

iangrunert force-pushed the ig/bug-284823-win-run-loop-improvements branch from b8a3e2e to b9d5665 Compare March 24, 2025 20:59

iangrunert force-pushed the ig/bug-284823-win-run-loop-improvements branch from b9d5665 to 9b6d578 Compare March 27, 2025 21:12

iangrunert force-pushed the ig/bug-284823-win-run-loop-improvements branch from 9b6d578 to ea2075e Compare March 27, 2025 21:22

iangrunert added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Mar 28, 2025

webkit-commit-queue force-pushed the ig/bug-284823-win-run-loop-improvements branch from ea2075e to 70d5b92 Compare March 28, 2025 19:51

webkit-commit-queue merged commit 70d5b92 into WebKit:main Mar 28, 2025

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Mar 28, 2025

fujii reviewed Mar 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Win] Improvements to run loop timer resolution #42936

[Win] Improvements to run loop timer resolution #42936

Uh oh!

iangrunert commented Mar 24, 2025 •

edited by webkit-early-warning-system

Loading

Uh oh!

webkit-early-warning-system commented Mar 24, 2025 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Mar 24, 2025 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Mar 24, 2025 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Mar 27, 2025 •

edited

Loading

Uh oh!

webkit-early-warning-system commented Mar 27, 2025 •

edited

Loading

Uh oh!

webkit-commit-queue commented Mar 28, 2025

Uh oh!

fujii commented Mar 28, 2025

Uh oh!

fujii Mar 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[Win] Improvements to run loop timer resolution #42936

[Win] Improvements to run loop timer resolution #42936

Uh oh!

Conversation

iangrunert commented Mar 24, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

70d5b92

Uh oh!

webkit-early-warning-system commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-commit-queue commented Mar 28, 2025

Uh oh!

fujii commented Mar 28, 2025

Uh oh!

fujii Mar 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

iangrunert commented Mar 24, 2025 •

edited by webkit-early-warning-system

Loading

`70d5b92`

webkit-early-warning-system commented Mar 24, 2025 •

edited

Loading

webkit-early-warning-system commented Mar 24, 2025 •

edited

Loading

webkit-early-warning-system commented Mar 24, 2025 •

edited

Loading

webkit-early-warning-system commented Mar 27, 2025 •

edited

Loading

webkit-early-warning-system commented Mar 27, 2025 •

edited

Loading