Skip to content

Conversation

@philn
Copy link
Member

@philn philn commented Sep 13, 2022

ce99e01

[ANGLE] build failing with gcc 12
https://bugs.webkit.org/show_bug.cgi?id=245127

Reviewed by Kenneth Russell.

bool std::__atomic_base<_IntTp>::is_lock_free() is not constexpr, so the AtomicQueueSerial
constructor can't be either.

* Source/ThirdParty/ANGLE/src/libANGLE/renderer/serial_utils.h:

Canonical link: https://commits.webkit.org/254470@main

47b5ea3

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

@philn philn self-assigned this Sep 13, 2022
@philn philn added ANGLE Bugs related to the ANGLE project WebKit Nightly Build labels Sep 13, 2022
@philn philn requested a review from kenrussell September 13, 2022 10:38
Copy link
Contributor

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me assuming it doesn't break compilation on any other platform.

Would you please upstream this change to the ANGLE repository? Here are instructions on how to do so:
https://chromium.googlesource.com/angle/angle/+/HEAD/doc/ContributingCode.md

Thanks.

@philn
Copy link
Member Author

philn commented Sep 14, 2022

Looks OK to me assuming it doesn't break compilation on any other platform.

Would you please upstream this change to the ANGLE repository? Here are instructions on how to do so: https://chromium.googlesource.com/angle/angle/+/HEAD/doc/ContributingCode.md

Thanks.

This looks complicated for a one-line patch... Let's see if I manage to embark on the journey...
Thanks for the review!

@philn philn added the merge-queue Applied to send a pull request to merge-queue label Sep 14, 2022
@webkit-commit-queue
Copy link
Collaborator

Committed 254470@main (ce99e01): https://commits.webkit.org/254470@main

Reviewed commits have been landed. Closing PR #4303 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 14, 2022
@philn philn deleted the eng/245127 branch September 14, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ANGLE Bugs related to the ANGLE project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants