[SwiftUI] Remove unused initial download support implementation#43367
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 1, 2025
Merged
[SwiftUI] Remove unused initial download support implementation#43367webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
rr-codes
added
the
New Bugs
Collaborator
|
EWS run on current version of this PR (hash f531f1b) Details |
hortont424
approved these changes
Apr 1, 2025
rr-codes
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=290819 rdar://148290059 Reviewed by Tim Horton. A version of this implementation may be used in the future, but for now this is unused code and also unnecessary SPI. * Source/WebKit/UIProcess/API/Swift/DownloadCoordinator.swift: Removed. * Source/WebKit/UIProcess/API/Swift/WebPage+Download.swift: Removed. * Source/WebKit/UIProcess/API/Swift/WebPage.swift: (startDownload(using:)): Deleted. (resumeDownload(fromResumeData:)): Deleted. * Source/WebKit/UIProcess/Cocoa/WKDownloadDelegateAdapter.swift: Removed. * Source/WebKit/UIProcess/Cocoa/WKNavigationDelegateAdapter.swift: (WKNavigationDelegateAdapter.yieldDownloadProgress(_:download:)): Deleted. (WKNavigationDelegateAdapter.webView(_:navigationAction:didBecome:)): Deleted. (WKNavigationDelegateAdapter.webView(_:navigationResponse:didBecome:)): Deleted. (WKNavigationDelegateAdapter._webView(_:contextMenuDidCreateDownload:)): Deleted. * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Tools/SwiftBrowser/Source/SwiftBrowser.swift: (SwiftBrowserApp.body): * Tools/SwiftBrowser/Source/ViewModel/BrowserViewModel.swift: * Tools/SwiftBrowser/Source/ViewModel/DownloadCoordinator.swift: Removed. * Tools/SwiftBrowser/Source/ViewModel/Downloadable.swift: Removed. * Tools/SwiftBrowser/Source/Views/ContentView.swift: (ContentView.body): * Tools/SwiftBrowser/Source/Views/DownloadsView.swift: Removed. * Tools/SwiftBrowser/SwiftBrowser.xcodeproj/project.pbxproj: Canonical link: https://commits.webkit.org/292981@main
webkit-commit-queue
force-pushed
the
eng/148290059
branch
from
f531f1b to
ebb382f
Compare
Collaborator
|
Committed 292981@main (ebb382f): https://commits.webkit.org/292981@main Reviewed commits have been landed. Closing PR #43367 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ebb382f
f531f1b
🛠 wpe🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-cairo🧪 api-ios🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 api-gtk🧪 vision-wk2🧪 mac-intel-wk2🛠 playstation🛠 mac-safer-cpp🛠 tv-sim🛠 watch