Skip to content

[build-webkit] JSC tests with '*** Warning' in logs breaks the filtering#43414

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
briannafan:eng/build-webkit-JSC-tests-with-Warning-in-logs-don-t-get-filtered
Apr 1, 2025
Merged

[build-webkit] JSC tests with '*** Warning' in logs breaks the filtering#43414
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
briannafan:eng/build-webkit-JSC-tests-with-Warning-in-logs-don-t-get-filtered

Conversation

@briannafan
Copy link
Copy Markdown
Contributor

@briannafan briannafan commented Apr 1, 2025

@briannafan briannafan self-assigned this Apr 1, 2025
@briannafan briannafan added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Apr 1, 2025
@briannafan briannafan requested review from aj062 and ryanhaddad April 1, 2025 22:26
@briannafan briannafan changed the title [build-webkit] JSC tests with '*** Warning' in logs don't get filtered [build-webkit] JSC tests with '*** Warning' in logs breaks the filtering Apr 1, 2025
@briannafan briannafan force-pushed the eng/build-webkit-JSC-tests-with-Warning-in-logs-don-t-get-filtered branch from 4be1c68 to a354837 Compare April 1, 2025 22:33
@briannafan briannafan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 1, 2025
https://bugs.webkit.org/show_bug.cgi?id=290872
rdar://148374240

Reviewed by Aakash Jain.

Ensure we only print logs after '** '.

* Tools/Scripts/filter-test-logs:
(filter_jsc_tests):

Canonical link: https://commits.webkit.org/293047@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/build-webkit-JSC-tests-with-Warning-in-logs-don-t-get-filtered branch from a354837 to e5a71f0 Compare April 1, 2025 22:37
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 293047@main (e5a71f0): https://commits.webkit.org/293047@main

Reviewed commits have been landed. Closing PR #43414 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit e5a71f0 into WebKit:main Apr 1, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 1, 2025
@briannafan briannafan deleted the eng/build-webkit-JSC-tests-with-Warning-in-logs-don-t-get-filtered branch April 1, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants