WebPageProxy::loadData should use baseURL to help decide what site the initial process should contain#43504
Merged
Conversation
Collaborator
|
EWS run on previous version of this PR (hash d2bcc51) Details |
d2bcc51 to
f02ddc4
Compare
Collaborator
|
EWS run on current version of this PR (hash f02ddc4) Details |
beidson
approved these changes
Apr 3, 2025
xeenon
approved these changes
Apr 3, 2025
…e initial process should contain https://bugs.webkit.org/show_bug.cgi?id=290964 Reviewed by Brady Eidson and Timothy Hatcher. With site isolation off this doesn't do anything, but with it on it makes the process accounting more accurate. Particularly in the case where we reuse a WKWebViewConfiguration for multiple WKWebViews, they are all in the same BrowsingContextGroup, which means the process for a particular site may already exist. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::loadData): * Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm: (TestWebKitAPI::TEST(SiteIsolation, ReuseConfigurationLoadHTMLString)): Canonical link: https://commits.webkit.org/293161@main
f02ddc4 to
afae607
Compare
Collaborator
|
Committed 293161@main (afae607): https://commits.webkit.org/293161@main Reviewed commits have been landed. Closing PR #43504 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
afae607
f02ddc4