Skip to content

WebPageProxy::loadData should use baseURL to help decide what site the initial process should contain#43504

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
achristensen07:eng/WebPageProxy-loadData-should-use-baseURL-to-help-decide-what-site-the-initial-process-should-contain
Apr 3, 2025
Merged

WebPageProxy::loadData should use baseURL to help decide what site the initial process should contain#43504
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
achristensen07:eng/WebPageProxy-loadData-should-use-baseURL-to-help-decide-what-site-the-initial-process-should-contain

Conversation

@achristensen07
Copy link
Copy Markdown
Contributor

@achristensen07 achristensen07 commented Apr 3, 2025

afae607

WebPageProxy::loadData should use baseURL to help decide what site the initial process should contain
https://bugs.webkit.org/show_bug.cgi?id=290964

Reviewed by Brady Eidson and Timothy Hatcher.

With site isolation off this doesn't do anything, but with it on it makes the process accounting
more accurate.  Particularly in the case where we reuse a WKWebViewConfiguration for multiple
WKWebViews, they are all in the same BrowsingContextGroup, which means the process for a particular
site may already exist.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadData):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, ReuseConfigurationLoadHTMLString)):

Canonical link: https://commits.webkit.org/293161@main

f02ddc4

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ⏳ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ⏳ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ⏳ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@achristensen07 achristensen07 requested a review from cdumez as a code owner April 3, 2025 00:54
@achristensen07 achristensen07 self-assigned this Apr 3, 2025
@achristensen07 achristensen07 added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Apr 3, 2025
@achristensen07 achristensen07 force-pushed the eng/WebPageProxy-loadData-should-use-baseURL-to-help-decide-what-site-the-initial-process-should-contain branch from d2bcc51 to f02ddc4 Compare April 3, 2025 00:55
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 3, 2025
…e initial process should contain

https://bugs.webkit.org/show_bug.cgi?id=290964

Reviewed by Brady Eidson and Timothy Hatcher.

With site isolation off this doesn't do anything, but with it on it makes the process accounting
more accurate.  Particularly in the case where we reuse a WKWebViewConfiguration for multiple
WKWebViews, they are all in the same BrowsingContextGroup, which means the process for a particular
site may already exist.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadData):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, ReuseConfigurationLoadHTMLString)):

Canonical link: https://commits.webkit.org/293161@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebPageProxy-loadData-should-use-baseURL-to-help-decide-what-site-the-initial-process-should-contain branch from f02ddc4 to afae607 Compare April 3, 2025 15:46
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 293161@main (afae607): https://commits.webkit.org/293161@main

Reviewed commits have been landed. Closing PR #43504 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit afae607 into WebKit:main Apr 3, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Process Model Bugs related to WebKit's multi-process architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants