Skip to content

[iOS] 2 layout tests fast/forms/date/date-*.html are failing#43625

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
lilyspiniolas:eng/144348683_2
Apr 4, 2025
Merged

[iOS] 2 layout tests fast/forms/date/date-*.html are failing#43625
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
lilyspiniolas:eng/144348683_2

Conversation

@lilyspiniolas
Copy link
Copy Markdown
Contributor

@lilyspiniolas lilyspiniolas commented Apr 4, 2025

1c3f2ad

[iOS] 2 layout tests fast/forms/date/date-*.html are failing
https://bugs.webkit.org/show_bug.cgi?id=287204
rdar://144348683

Reviewed by Megan Gardner, Abrar Rahman Protyasha, and Aditya Keerthi.

The width of date controls has increased due to 292441@main
calculating a larger estimated maximum width. Updated the
test expectations for date-pseudo-elements.html &
date-input-rendering-basic-expected.html to account for
this.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/ios/fast/forms/date/date-input-rendering-basic-expected.txt:
* LayoutTests/platform/ios/fast/forms/date/date-pseudo-elements-expected.txt:

Canonical link: https://commits.webkit.org/293256@main

9ff9000

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@lilyspiniolas lilyspiniolas self-assigned this Apr 4, 2025
@lilyspiniolas lilyspiniolas added the Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.) label Apr 4, 2025
@lilyspiniolas lilyspiniolas added the merge-queue Applied to send a pull request to merge-queue label Apr 4, 2025
https://bugs.webkit.org/show_bug.cgi?id=287204
rdar://144348683

Reviewed by Megan Gardner, Abrar Rahman Protyasha, and Aditya Keerthi.

The width of date controls has increased due to 292441@main
calculating a larger estimated maximum width. Updated the
test expectations for date-pseudo-elements.html &
date-input-rendering-basic-expected.html to account for
this.

* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/ios/fast/forms/date/date-input-rendering-basic-expected.txt:
* LayoutTests/platform/ios/fast/forms/date/date-pseudo-elements-expected.txt:

Canonical link: https://commits.webkit.org/293256@main
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 293256@main (1c3f2ad): https://commits.webkit.org/293256@main

Reviewed commits have been landed. Closing PR #43625 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1c3f2ad into WebKit:main Apr 4, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Forms For bugs specific to form elements (checkboxes, buttons, text fields, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants