Skip to content

REGRESSION(291827@main): [macOS] TestWebKitAPI.WebKit.AccessibilityChildrenPreventsProcessSuspensionOnFrontmostTab is a constant failure#43748

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
pvollan:eng/REGRESSION-291827-main-MacOS-TestWebKitAPI-WebKit-AccessibilityChildrenPreventsProcessSuspensionOnFrontmostTab-is-a-constant-failure
Apr 8, 2025
Merged

REGRESSION(291827@main): [macOS] TestWebKitAPI.WebKit.AccessibilityChildrenPreventsProcessSuspensionOnFrontmostTab is a constant failure#43748
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
pvollan:eng/REGRESSION-291827-main-MacOS-TestWebKitAPI-WebKit-AccessibilityChildrenPreventsProcessSuspensionOnFrontmostTab-is-a-constant-failure

Conversation

@pvollan
Copy link
Copy Markdown
Contributor

@pvollan pvollan commented Apr 7, 2025

ad66ae8

REGRESSION(291827@main): [macOS] TestWebKitAPI.WebKit.AccessibilityChildrenPreventsProcessSuspensionOnFrontmostTab is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=291204
rdar://148554890

Reviewed by Chris Dumez.

When starting Accessibility on demand in the WebContent process, we should still send the AX remote token data to the UI process
on process initialization. This will resolve a race conditions where the AX remote tokens may not have been received in the UI
process before the first AX request.

* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformInitializeAccessibility):
(WebKit::WebPage::initializeAccessibility):

Canonical link: https://commits.webkit.org/293411@main

3ba3476

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan pvollan requested a review from cdumez as a code owner April 7, 2025 16:18
@pvollan pvollan self-assigned this Apr 7, 2025
@pvollan pvollan added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Apr 7, 2025
@pvollan pvollan added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 8, 2025
@pvollan
Copy link
Copy Markdown
Contributor Author

pvollan commented Apr 8, 2025

Thanks for reviewing!

…ildrenPreventsProcessSuspensionOnFrontmostTab is a constant failure

https://bugs.webkit.org/show_bug.cgi?id=291204
rdar://148554890

Reviewed by Chris Dumez.

When starting Accessibility on demand in the WebContent process, we should still send the AX remote token data to the UI process
on process initialization. This will resolve a race conditions where the AX remote tokens may not have been received in the UI
process before the first AX request.

* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformInitializeAccessibility):
(WebKit::WebPage::initializeAccessibility):

Canonical link: https://commits.webkit.org/293411@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION-291827-main-MacOS-TestWebKitAPI-WebKit-AccessibilityChildrenPreventsProcessSuspensionOnFrontmostTab-is-a-constant-failure branch from 3ba3476 to ad66ae8 Compare April 8, 2025 11:51
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 293411@main (ad66ae8): https://commits.webkit.org/293411@main

Reviewed commits have been landed. Closing PR #43748 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ad66ae8 into WebKit:main Apr 8, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WebKit Process Model Bugs related to WebKit's multi-process architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants