Skip to content

Clean up dead callee BitVector in LLInt/IPInt generators#44212

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
danlliu:149052721-remove-dead-bitvector
Apr 17, 2025
Merged

Clean up dead callee BitVector in LLInt/IPInt generators#44212
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
danlliu:149052721-remove-dead-bitvector

Conversation

@danlliu
Copy link
Copy Markdown
Contributor

@danlliu danlliu commented Apr 17, 2025

2faf0a6

Clean up dead callee BitVector in LLInt/IPInt generators
https://bugs.webkit.org/show_bug.cgi?id=291699
rdar://149052721

Reviewed by Yijia Huang.

Previously, we used this BitVector to track external functions, but now it is no
longer used by the code. We can remove this unnecessary allocation.

* JSTests/wasm/stress/initialize-100k-functions.js: Added.
(async main):
* JSTests/wasm/stress/initialize-100k-functions.wasm: Added.
* Source/JavaScriptCore/wasm/WasmFunctionCodeBlockGenerator.h:
(JSC::Wasm::FunctionCodeBlockGenerator::tailCallSuccessors const):
(JSC::Wasm::FunctionCodeBlockGenerator::takeCallees): Deleted.
* Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h:
(JSC::Wasm::FunctionIPIntMetadataGenerator::takeCallees): Deleted.
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::IPIntGenerator):
(JSC::Wasm::IPIntGenerator::addCall):
* Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::LLIntGenerator):
(JSC::Wasm::LLIntGenerator::addCall):

Canonical link: https://commits.webkit.org/293831@main

d617b3a

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@danlliu danlliu requested a review from a team as a code owner April 17, 2025 18:43
@danlliu danlliu self-assigned this Apr 17, 2025
@danlliu danlliu added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Apr 17, 2025
Copy link
Copy Markdown
Contributor

@hyjorc1 hyjorc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Apr 17, 2025
@danlliu danlliu removed the merging-blocked Applied to prevent a change from being merged label Apr 17, 2025
@danlliu danlliu force-pushed the 149052721-remove-dead-bitvector branch from 1c6716d to c44d351 Compare April 17, 2025 20:04
@danlliu danlliu force-pushed the 149052721-remove-dead-bitvector branch from c44d351 to d617b3a Compare April 17, 2025 21:17
@danlliu danlliu added the merge-queue Applied to send a pull request to merge-queue label Apr 17, 2025
https://bugs.webkit.org/show_bug.cgi?id=291699
rdar://149052721

Reviewed by Yijia Huang.

Previously, we used this BitVector to track external functions, but now it is no
longer used by the code. We can remove this unnecessary allocation.

* JSTests/wasm/stress/initialize-100k-functions.js: Added.
(async main):
* JSTests/wasm/stress/initialize-100k-functions.wasm: Added.
* Source/JavaScriptCore/wasm/WasmFunctionCodeBlockGenerator.h:
(JSC::Wasm::FunctionCodeBlockGenerator::tailCallSuccessors const):
(JSC::Wasm::FunctionCodeBlockGenerator::takeCallees): Deleted.
* Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h:
(JSC::Wasm::FunctionIPIntMetadataGenerator::takeCallees): Deleted.
* Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp:
(JSC::Wasm::IPIntGenerator::IPIntGenerator):
(JSC::Wasm::IPIntGenerator::addCall):
* Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp:
(JSC::Wasm::LLIntGenerator::LLIntGenerator):
(JSC::Wasm::LLIntGenerator::addCall):

Canonical link: https://commits.webkit.org/293831@main
@webkit-commit-queue webkit-commit-queue force-pushed the 149052721-remove-dead-bitvector branch from d617b3a to 2faf0a6 Compare April 17, 2025 23:57
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 293831@main (2faf0a6): https://commits.webkit.org/293831@main

Reviewed commits have been landed. Closing PR #44212 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2faf0a6 into WebKit:main Apr 17, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants