Clean up dead callee BitVector in LLInt/IPInt generators#44212
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 17, 2025
Merged
Clean up dead callee BitVector in LLInt/IPInt generators#44212webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on previous version of this PR (hash 1c6716d) Details |
1c6716d to
c44d351
Compare
Collaborator
|
EWS run on previous version of this PR (hash c44d351) Details |
c44d351 to
d617b3a
Compare
Collaborator
|
EWS run on current version of this PR (hash d617b3a) Details |
https://bugs.webkit.org/show_bug.cgi?id=291699 rdar://149052721 Reviewed by Yijia Huang. Previously, we used this BitVector to track external functions, but now it is no longer used by the code. We can remove this unnecessary allocation. * JSTests/wasm/stress/initialize-100k-functions.js: Added. (async main): * JSTests/wasm/stress/initialize-100k-functions.wasm: Added. * Source/JavaScriptCore/wasm/WasmFunctionCodeBlockGenerator.h: (JSC::Wasm::FunctionCodeBlockGenerator::tailCallSuccessors const): (JSC::Wasm::FunctionCodeBlockGenerator::takeCallees): Deleted. * Source/JavaScriptCore/wasm/WasmFunctionIPIntMetadataGenerator.h: (JSC::Wasm::FunctionIPIntMetadataGenerator::takeCallees): Deleted. * Source/JavaScriptCore/wasm/WasmIPIntGenerator.cpp: (JSC::Wasm::IPIntGenerator::IPIntGenerator): (JSC::Wasm::IPIntGenerator::addCall): * Source/JavaScriptCore/wasm/WasmLLIntGenerator.cpp: (JSC::Wasm::LLIntGenerator::LLIntGenerator): (JSC::Wasm::LLIntGenerator::addCall): Canonical link: https://commits.webkit.org/293831@main
d617b3a to
2faf0a6
Compare
Collaborator
|
Committed 293831@main (2faf0a6): https://commits.webkit.org/293831@main Reviewed commits have been landed. Closing PR #44212 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2faf0a6
d617b3a
🧪 api-wpe🧪 gtk-wk2