Try to fix the tvOS build after 293779@main#44224
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 17, 2025
Merged
Try to fix the tvOS build after 293779@main#44224webkit-commit-queue merged 1 commit intoWebKit:mainfrom
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
Conversation
Collaborator
|
EWS run on current version of this PR (hash 9543f51) Details |
🛠 playstation
aestes
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=291712 Unreviewed build fix; called createNSString() instead of relying on implicit WTFString->NSString conversion. While here, fixed a comment in WTFString.h that claimed we still support this type of implicit conversion. * Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::updateNowPlayingSuppression): Canonical link: https://commits.webkit.org/293821@main
webkit-commit-queue
force-pushed
the
eng/Try-to-fix-the-tvOS-build-after-293779-main
branch
from
9543f51 to
03557b4
Compare
Collaborator
|
Committed 293821@main (03557b4): https://commits.webkit.org/293821@main Reviewed commits have been landed. Closing PR #44224 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
03557b4
9543f51
🛠 ios🛠 wpe🛠 win🛠 mac-AS-debug🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🛠 wpe-cairo🧪 api-ios🧪 mac-wk2🛠 gtk🛠 vision🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 vision-sim🧪 mac-wk2-stress🧪 api-gtk🧪 mac-intel-wk2🛠 tv🛠 mac-safer-cpp🛠 tv-sim🛠 watch🛠 watch-sim