[web-animations] remove the notion of an overriding start time when computing timing#44459
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 24, 2025
Conversation
graouts
added
the
Animations
Collaborator
|
EWS run on previous version of this PR (hash e7cde98) Details |
annevk
approved these changes
Apr 24, 2025
Source/WebCore/style/Styleable.cpp
Outdated
Contributor
There was a problem hiding this comment.
Would it make sense to introduce protectedAnimation?
Contributor
Author
There was a problem hiding this comment.
A quick search for Ref { in Source/WebCore/animation shows that this is the only place where we'd use such a new method, so I'm not sure it's worth it. That said, I'm sure there's plenty left to do to make that directory adhere to the memory safety programming guidelines, so perhaps in the future.
Collaborator
Safer C++ Build #33018 (e7cde98)
|
graouts
force-pushed
the
eng/web-animations-remove-the-notion-of-an-explicit-start-time-when-computing-timing
branch
from
e7cde98 to
7130211
Compare
graouts
added
the
unsafe-merge-queue
Collaborator
|
EWS run on current version of this PR (hash 7130211) Details |
…omputing timing https://bugs.webkit.org/show_bug.cgi?id=292000 Reviewed by Anne van Kesteren. In 226359@main and 226577@main we added the notion of an overriding start time when computing timing, to work around some compatibility issue with CSS Transitions that is not longer required following the timing changes introduced by 294049@main. We now remove this notion entirely. * Source/WebCore/SaferCPPExpectations/UncheckedCallArgsCheckerExpectations: * Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations: * Source/WebCore/animation/AnimationEffect.cpp: (WebCore::AnimationEffect::resolutionData const): (WebCore::AnimationEffect::getBasicTiming): (WebCore::AnimationEffect::getComputedTiming): * Source/WebCore/animation/AnimationEffect.h: * Source/WebCore/animation/CSSTransition.cpp: (WebCore::CSSTransition::CSSTransition): (WebCore::CSSTransition::resolve): * Source/WebCore/animation/CSSTransition.h: * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::apply): * Source/WebCore/animation/KeyframeEffect.h: * Source/WebCore/animation/WebAnimation.cpp: (WebCore::WebAnimation::currentTime const): (WebCore::WebAnimation::resolve): * Source/WebCore/animation/WebAnimation.h: * Source/WebCore/style/Styleable.cpp: (WebCore::updateCSSTransitionsForStyleableAndProperty): Canonical link: https://commits.webkit.org/294056@main
webkit-commit-queue
force-pushed
the
eng/web-animations-remove-the-notion-of-an-explicit-start-time-when-computing-timing
branch
from
7130211 to
0f7edc3
Compare
Collaborator
|
Committed 294056@main (0f7edc3): https://commits.webkit.org/294056@main Reviewed commits have been landed. Closing PR #44459 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
graouts
deleted the
eng/web-animations-remove-the-notion-of-an-explicit-start-time-when-computing-timing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0f7edc3
7130211
🛠 wpe🧪 wpe-wk2🧪 win-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-wk2🛠 gtk🧪 mac-AS-debug-wk2🧪 gtk-wk2🧪 mac-wk2-stress🧪 api-gtk🧪 vision-wk2🧪 mac-intel-wk2🛠 playstation