[css-anchor-position-1] Put position-visibility under a separate feature flag#44713
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom Apr 30, 2025
Conversation
Collaborator
|
EWS run on current version of this PR (hash b356b95) Details |
anttijk
approved these changes
Apr 30, 2025
…ure flag rdar://150086754 https://bugs.webkit.org/show_bug.cgi?id=292090 Reviewed by Antti Koivisto. Currently, all CSS anchor positioning features are behind an enabled-by-default flag, CSSAnchorPositioningEnabled. However, position-visibility hasn't reached feature complete yet (parsing is implemented but not layout implementation), so put it under a separate, disabled-by-default flag. * LayoutTests/fast/css/css-anchor-position/anchor-feature-disabled-expected.txt: * LayoutTests/fast/css/css-anchor-position/anchor-feature-disabled.html: - Added tests to ensure position-visibility doesn't parse when the feature flag is disabled. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: - Added new feature flag for position-visibility. * Source/WebCore/css/CSSProperties.json: - Changed position-visibility to use the new feature flag. Canonical link: https://commits.webkit.org/294361@main
b356b95 to
5cbd2c6
Compare
Collaborator
|
Committed 294361@main (5cbd2c6): https://commits.webkit.org/294361@main Reviewed commits have been landed. Closing PR #44713 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5cbd2c6
b356b95