Skip to content

Forward com.apple.system.console_mode_changed from libnotifyd to WebContent on embedded platforms.#44828

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
bls1999:eng/149724385
May 2, 2025
Merged

Forward com.apple.system.console_mode_changed from libnotifyd to WebContent on embedded platforms.#44828
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
bls1999:eng/149724385

Conversation

@bls1999
Copy link
Contributor

@bls1999 bls1999 commented May 2, 2025 •
edited by webkit-early-warning-system
Loading

8338f54

Forward `com.apple.system.console_mode_changed` from libnotifyd to WebContent on embedded platforms.
https://bugs.webkit.org/show_bug.cgi?id=292419
rdar://149724385

Reviewed by Jonathan Bedard and Per Arne Vollan.

When running WebKitTestRunnerApp, we noticed that there are a lot of user fault
logs being generated. Some digging revealed that these are being generated
because some libnotifyd notifications aren't being forwarded to the WebContent
process on embedded platforms. This change adds one of those notifications to
the forwarding list, `com.apple.system.console_mode_changed`.

* Source/WebKit/Resources/cocoa/NotificationAllowList/EmbeddedForwardedNotifications.def: Add `com.apple.system.console_mode_changed` to the forwarding list.

Canonical link: https://commits.webkit.org/294438@main

683bf48

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win
loading 🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl loading 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
loading 🧪 ios-wk2-wpt   🛠 wpe-cairo
loading 🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge   🛠 tv ❌ 🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@bls1999 bls1999 self-assigned this May 2, 2025
@bls1999 bls1999 added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label May 2, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 2, 2025 •
edited
Loading

EWS run on previous version of this PR (hash aa24780)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim loading 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

pvollan
pvollan approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@pvollan pvollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me.

@bls1999 bls1999 changed the title Add "com.apple.system.console_mode_changed" to EmbeddedForwardedNotifications.def. Forward more notifications from libnotifyd to WebContent on embedded platforms. May 2, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 2, 2025 •
edited
Loading

EWS run on previous version of this PR (hash 6d4462f)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
  🧪 ios-wk2-wpt   🛠 wpe-cairo
  🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
  🛠 tv ✅ 🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@bls1999 bls1999 added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label May 2, 2025
@bls1999 bls1999 changed the title Forward more notifications from libnotifyd to WebContent on embedded platforms. Forward com.apple.system.console_mode_changed from libnotifyd to WebContent on embedded platforms. May 2, 2025
@bls1999 bls1999 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 2, 2025
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented May 2, 2025 •
edited
Loading

EWS run on current version of this PR (hash 683bf48)

Details

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac   🛠 wpe   🛠 win
loading 🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2   🧪 win-tests
✅ 🧪 webkitperl loading 🧪 ios-wk2   🧪 api-mac   🧪 api-wpe
loading 🧪 ios-wk2-wpt   🛠 wpe-cairo
loading 🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 vision   🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 vision-sim   🧪 mac-wk2-stress   🧪 api-gtk
⏳ 🧪 vision-wk2   🧪 mac-intel-wk2   🛠 playstation
✅ 🛠 🧪 unsafe-merge   🛠 tv ❌ 🛠 mac-safer-cpp
  🛠 tv-sim
  🛠 watch
  🛠 watch-sim

@bls1999
Forward com.apple.system.console_mode_changed from libnotifyd to We…
8338f54 
…bContent on embedded platforms.

https://bugs.webkit.org/show_bug.cgi?id=292419
rdar://149724385

Reviewed by Jonathan Bedard and Per Arne Vollan.

When running WebKitTestRunnerApp, we noticed that there are a lot of user fault
logs being generated. Some digging revealed that these are being generated
because some libnotifyd notifications aren't being forwarded to the WebContent
process on embedded platforms. This change adds one of those notifications to
the forwarding list, `com.apple.system.console_mode_changed`.

* Source/WebKit/Resources/cocoa/NotificationAllowList/EmbeddedForwardedNotifications.def: Add `com.apple.system.console_mode_changed` to the forwarding list.

Canonical link: https://commits.webkit.org/294438@main
@webkit-commit-queue webkit-commit-queue merged commit 8338f54 into WebKit:main May 2, 2025
@webkit-commit-queue
Copy link
Collaborator

webkit-commit-queue commented May 2, 2025

Committed 294438@main (8338f54): https://commits.webkit.org/294438@main

Reviewed commits have been landed. Closing PR #44828 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonWBedard JonWBedard JonWBedard approved these changes

@pvollan pvollan pvollan approved these changes

Assignees

@bls1999 bls1999

Labels

Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bls1999 @webkit-early-warning-system @webkit-commit-queue @JonWBedard @pvollan