Skip to content

[Curl][WebDriver]: support acceptInsecureCerts capability#44960

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
yury-s:eng/WebDriver-Bidi-Curl-support-acceptInsecureCerts-capability
May 7, 2025
Merged

[Curl][WebDriver]: support acceptInsecureCerts capability#44960
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
yury-s:eng/WebDriver-Bidi-Curl-support-acceptInsecureCerts-capability

Conversation

@yury-s
Copy link
Copy Markdown
Contributor

@yury-s yury-s commented May 5, 2025

f4806cb

[Curl][WebDriver]: support acceptInsecureCerts capability
https://bugs.webkit.org/show_bug.cgi?id=292564

Reviewed by Michael Catanzaro and Don Olmstead.

The same logic as was used in libsoup is extended to Curl. The
flag is propagated down to the Curl implementation in the network
process.

* Source/WebCore/platform/network/curl/CurlStream.cpp:
(WebCore::CurlStream::CurlStream):
* Source/WebCore/platform/network/curl/CurlStream.h:
(WebCore::CurlStream::create):
* Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp:
(WebCore::CurlStreamScheduler::createStream):
* Source/WebCore/platform/network/curl/CurlStreamScheduler.h:
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h:
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in:
* Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::NetworkDataTaskCurl):
(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection):
* Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::setIgnoreTLSErrors):
* Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp:
(WebKit::NetworkSessionCurl::createWebSocketTask):
* Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.h:
* Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp:
(WebKit::WebSocketTask::WebSocketTask):
(WebKit::WebSocketTask::tryServerTrustEvaluation):
* Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.h:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::parameters):
(WebKit::WebsiteDataStore::setIgnoreTLSErrors):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::persistentCredentialStorageEnabled const):
(WebKit::WebsiteDataStore::ignoreTLSErrors const): Deleted.
* Source/WebKit/UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp:
(WebKit::WebsiteDataStore::platformSetNetworkParameters):
(WebKit::WebsiteDataStore::setIgnoreTLSErrors): Deleted.
* Source/WebKit/UIProcess/win/AutomationClientWin.cpp:
(WebKit::AutomationClient::requestAutomationSession):

Canonical link: https://commits.webkit.org/294594@main

284b466

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 ❌ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@yury-s yury-s requested review from a team and cdumez as code owners May 5, 2025 22:14
@yury-s yury-s self-assigned this May 5, 2025
@yury-s yury-s added the Web Inspector Bugs related to the WebKit Web Inspector. label May 5, 2025
@yury-s yury-s requested review from burg, donny-dont, fujii and mcatanzaro May 5, 2025 22:45
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 6, 2025
@yury-s yury-s requested a review from basuke May 6, 2025 16:31
Comment thread Source/WebCore/platform/network/curl/CurlStream.cpp Outdated
@mcatanzaro
Copy link
Copy Markdown
Contributor

Please put [Curl] at the start of your commit message, to follow the convention for commits that primarily touch curl support. Notably, this is almost all changes to the curl backend and only a few lines touching WebDriver directly.

@yury-s yury-s removed the merging-blocked Applied to prevent a change from being merged label May 6, 2025
@yury-s yury-s changed the title [WebDriver][Bidi] Curl: support acceptInsecureCerts capability [Curl][WebDriver]: support acceptInsecureCerts capability May 6, 2025
@yury-s yury-s force-pushed the eng/WebDriver-Bidi-Curl-support-acceptInsecureCerts-capability branch from 83ba603 to 284b466 Compare May 6, 2025 22:50
@yury-s
Copy link
Copy Markdown
Contributor Author

yury-s commented May 6, 2025

Please put [Curl] at the start of your commit message, to follow the convention for commits that primarily touch curl support. Notably, this is almost all changes to the curl backend and only a few lines touching WebDriver directly.

Done.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 7, 2025
@donny-dont donny-dont added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 7, 2025
https://bugs.webkit.org/show_bug.cgi?id=292564

Reviewed by Michael Catanzaro and Don Olmstead.

The same logic as was used in libsoup is extended to Curl. The
flag is propagated down to the Curl implementation in the network
process.

* Source/WebCore/platform/network/curl/CurlStream.cpp:
(WebCore::CurlStream::CurlStream):
* Source/WebCore/platform/network/curl/CurlStream.h:
(WebCore::CurlStream::create):
* Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp:
(WebCore::CurlStreamScheduler::createStream):
* Source/WebCore/platform/network/curl/CurlStreamScheduler.h:
* Source/WebKit/NetworkProcess/NetworkProcess.h:
* Source/WebKit/NetworkProcess/NetworkProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h:
* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.serialization.in:
* Source/WebKit/NetworkProcess/curl/NetworkDataTaskCurl.cpp:
(WebKit::NetworkDataTaskCurl::NetworkDataTaskCurl):
(WebKit::NetworkDataTaskCurl::willPerformHTTPRedirection):
* Source/WebKit/NetworkProcess/curl/NetworkProcessCurl.cpp:
(WebKit::NetworkProcess::setIgnoreTLSErrors):
* Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.cpp:
(WebKit::NetworkSessionCurl::createWebSocketTask):
* Source/WebKit/NetworkProcess/curl/NetworkSessionCurl.h:
* Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.cpp:
(WebKit::WebSocketTask::WebSocketTask):
(WebKit::WebSocketTask::tryServerTrustEvaluation):
* Source/WebKit/NetworkProcess/curl/WebSocketTaskCurl.h:
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::parameters):
(WebKit::WebsiteDataStore::setIgnoreTLSErrors):
* Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:
(WebKit::WebsiteDataStore::persistentCredentialStorageEnabled const):
(WebKit::WebsiteDataStore::ignoreTLSErrors const): Deleted.
* Source/WebKit/UIProcess/WebsiteData/soup/WebsiteDataStoreSoup.cpp:
(WebKit::WebsiteDataStore::platformSetNetworkParameters):
(WebKit::WebsiteDataStore::setIgnoreTLSErrors): Deleted.
* Source/WebKit/UIProcess/win/AutomationClientWin.cpp:
(WebKit::AutomationClient::requestAutomationSession):

Canonical link: https://commits.webkit.org/294594@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebDriver-Bidi-Curl-support-acceptInsecureCerts-capability branch from 284b466 to f4806cb Compare May 7, 2025 02:41
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 294594@main (f4806cb): https://commits.webkit.org/294594@main

Reviewed commits have been landed. Closing PR #44960 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f4806cb into WebKit:main May 7, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 7, 2025
@philn
Copy link
Copy Markdown
Member

philn commented May 8, 2025

Looks like this broke 400+ layout tests (see also EWS...). Is anyone taking a look?

@philn
Copy link
Copy Markdown
Member

philn commented May 8, 2025

Reverting in https://bugs.webkit.org/show_bug.cgi?id=292714.

@yury-s
Copy link
Copy Markdown
Contributor Author

yury-s commented May 8, 2025

Looks like this broke 400+ layout tests (see also EWS...). Is anyone taking a look?

Looking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Web Inspector Bugs related to the WebKit Web Inspector.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants