[webkitpy] Add VisionOSDevicePort.#45505
Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom May 16, 2025
Merged
Conversation
Collaborator
|
EWS run on current version of this PR (hash 0e6e56f) Details |
JonWBedard
reviewed
May 16, 2025
Member
There was a problem hiding this comment.
Do we need this change for visionOS? This seems more related to iOS.
Contributor
Author
There was a problem hiding this comment.
Yeah, this allows device-specific baseline mapping.
gsnedders
approved these changes
May 16, 2025
Member
gsnedders
left a comment
There was a problem hiding this comment.
I still wish we could do better at unifying more of all of the Apple embedded platform ports, but I don't think it makes sense to block this PR on that.
https://bugs.webkit.org/show_bug.cgi?id=293140 rdar://151479231 Reviewed by Sam Sneddon. This PR adds a port for visionOS devices, as Vision is the only simulated device type that doesn't have a matching device port. * Tools/Scripts/webkitpy/common/system/platforminfo.py: (PlatformInfo): -> (is_visionos): Returns true if the platform is visionOS. -> (_determine_os_name): Adds a switch case that 'visionos' if the platform is visionOS. * Tools/Scripts/webkitpy/port/factory.py: (PortFactory): -> (PORT_CLASSES): Add VisionOSDevicePort. * Tools/Scripts/webkitpy/port/visionos.py: (VisionOSPort): -> (CURRENT_VERSION): Bump to 2. -> (default_baseline_search_path): Differentiate between simulator and device. * Tools/Scripts/webkitpy/port/visionos_device.py: Added. * Tools/Scripts/webkitpy/xcode/device_type.py: (DeviceType): -> (_define_software_variant_from_hardware_family): Add handling for visionOS that is consistent with other platforms. -> (check_consistency): Ditto. Canonical link: https://commits.webkit.org/295033@main
0e6e56f to
588c4da
Compare
Collaborator
|
Committed 295033@main (588c4da): https://commits.webkit.org/295033@main Reviewed commits have been landed. Closing PR #45505 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
588c4da
0e6e56f
🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-AS-debug-wk2