Skip to content

[webkitpy] Add VisionOSDevicePort.#45505

Merged
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
bls1999:eng/151479231
May 16, 2025
Merged

[webkitpy] Add VisionOSDevicePort.#45505
webkit-commit-queue merged 1 commit intoWebKit:mainfrom
bls1999:eng/151479231

Conversation

@bls1999
Copy link
Contributor

@bls1999 bls1999 commented May 16, 2025

588c4da

[webkitpy] Add VisionOSDevicePort.
https://bugs.webkit.org/show_bug.cgi?id=293140
rdar://151479231

Reviewed by Sam Sneddon.

This PR adds a port for visionOS devices, as Vision is the only simulated
device type that doesn't have a matching device port.

* Tools/Scripts/webkitpy/common/system/platforminfo.py:
    (PlatformInfo):
        -> (is_visionos): Returns true if the platform is visionOS.
        -> (_determine_os_name): Adds a switch case that 'visionos' if the platform is visionOS.
* Tools/Scripts/webkitpy/port/factory.py:
    (PortFactory):
        -> (PORT_CLASSES): Add VisionOSDevicePort.
* Tools/Scripts/webkitpy/port/visionos.py:
    (VisionOSPort):
        -> (CURRENT_VERSION): Bump to 2.
        -> (default_baseline_search_path): Differentiate between simulator and device.
* Tools/Scripts/webkitpy/port/visionos_device.py: Added.
* Tools/Scripts/webkitpy/xcode/device_type.py:
    (DeviceType):
        -> (_define_software_variant_from_hardware_family): Add handling for visionOS that is consistent with other platforms.
        -> (check_consistency): Ditto.

Canonical link: https://commits.webkit.org/295033@main

0e6e56f

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac 🧪 api-wpe
✅ 🧪 webkitpy 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 🧪 unsafe-merge ✅ 🛠 tv
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@bls1999 bls1999 self-assigned this May 16, 2025
@bls1999 bls1999 added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label May 16, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change for visionOS? This seems more related to iOS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this allows device-specific baseline mapping.

Copy link
Member

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still wish we could do better at unifying more of all of the Apple embedded platform ports, but I don't think it makes sense to block this PR on that.

@bls1999 bls1999 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 16, 2025
https://bugs.webkit.org/show_bug.cgi?id=293140
rdar://151479231

Reviewed by Sam Sneddon.

This PR adds a port for visionOS devices, as Vision is the only simulated
device type that doesn't have a matching device port.

* Tools/Scripts/webkitpy/common/system/platforminfo.py:
    (PlatformInfo):
        -> (is_visionos): Returns true if the platform is visionOS.
        -> (_determine_os_name): Adds a switch case that 'visionos' if the platform is visionOS.
* Tools/Scripts/webkitpy/port/factory.py:
    (PortFactory):
        -> (PORT_CLASSES): Add VisionOSDevicePort.
* Tools/Scripts/webkitpy/port/visionos.py:
    (VisionOSPort):
        -> (CURRENT_VERSION): Bump to 2.
        -> (default_baseline_search_path): Differentiate between simulator and device.
* Tools/Scripts/webkitpy/port/visionos_device.py: Added.
* Tools/Scripts/webkitpy/xcode/device_type.py:
    (DeviceType):
        -> (_define_software_variant_from_hardware_family): Add handling for visionOS that is consistent with other platforms.
        -> (check_consistency): Ditto.

Canonical link: https://commits.webkit.org/295033@main
@webkit-commit-queue
Copy link
Collaborator

Committed 295033@main (588c4da): https://commits.webkit.org/295033@main

Reviewed commits have been landed. Closing PR #45505 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 588c4da into WebKit:main May 16, 2025
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants