AbortController.signal.reason is lost after garbage collection#45986
Merged
webkit-commit-queue merged 1 commit intoJun 2, 2025
Conversation
Collaborator
|
EWS run on previous version of this PR (hash f797f7d) Details |
cdumez
approved these changes
May 28, 2025
Contributor
Author
|
I forgot the radar link in the commit msg, will add it... |
f797f7d to
aa016ad
Compare
Collaborator
|
EWS run on current version of this PR (hash aa016ad) Details |
https://bugs.webkit.org/show_bug.cgi?id=293319 rdar://problem/152111446 Reviewed by Per Arne Vollan and Chris Dumez. Make sure that JSAbortController marks its signal reason to prevent GC. * LayoutTests/http/tests/fetch/abort-signal-gc-expected.txt: * LayoutTests/http/tests/fetch/abort-signal-gc.html: * Source/WebCore/dom/AbortController.cpp: (WebCore::JSAbortController::visitAdditionalChildren): * Source/WebCore/dom/AbortController.idl: Canonical link: https://commits.webkit.org/295688@main
aa016ad to
f1292b5
Compare
Collaborator
|
Committed 295688@main (f1292b5): https://commits.webkit.org/295688@main Reviewed commits have been landed. Closing PR #45986 and removing active labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 vision-sim
f1292b5
aa016ad
🧪 wpe-wk2🧪 ios-wk2-wpt🧪 gtk-wk2