Skip to content

AbortController.signal.reason is lost after garbage collection#45986

Merged
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
youennf:eng/AbortController-signal-reason-is-lost-after-garbage-collection
Jun 2, 2025
Merged

AbortController.signal.reason is lost after garbage collection#45986
webkit-commit-queue merged 1 commit into
WebKit:mainfrom
youennf:eng/AbortController-signal-reason-is-lost-after-garbage-collection

Conversation

@youennf
Copy link
Copy Markdown
Contributor

@youennf youennf commented May 28, 2025

f1292b5

AbortController.signal.reason is lost after garbage collection
https://bugs.webkit.org/show_bug.cgi?id=293319
rdar://problem/152111446

Reviewed by Per Arne Vollan and Chris Dumez.

Make sure that JSAbortController marks its signal reason to prevent GC.

* LayoutTests/http/tests/fetch/abort-signal-gc-expected.txt:
* LayoutTests/http/tests/fetch/abort-signal-gc.html:
* Source/WebCore/dom/AbortController.cpp:
(WebCore::JSAbortController::visitAdditionalChildren):
* Source/WebCore/dom/AbortController.idl:

Canonical link: https://commits.webkit.org/295688@main

aa016ad

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug 🧪 wpe-wk2 ⏳ 🧪 win-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 mac-AS-debug-wk2 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 🧪 merge ✅ 🧪 vision-wk2 ✅ 🧪 mac-intel-wk2 ✅ 🛠 playstation
✅ 🛠 tv ✅ 🛠 mac-safer-cpp
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@youennf youennf self-assigned this May 28, 2025
@youennf youennf added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label May 28, 2025
@youennf youennf marked this pull request as ready for review May 28, 2025 10:53
@youennf youennf requested review from cdumez and rniwa as code owners May 28, 2025 10:53
Copy link
Copy Markdown
Contributor

@pvollan pvollan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R=me.

@youennf
Copy link
Copy Markdown
Contributor Author

youennf commented Jun 2, 2025

I forgot the radar link in the commit msg, will add it...

@youennf youennf force-pushed the eng/AbortController-signal-reason-is-lost-after-garbage-collection branch from f797f7d to aa016ad Compare June 2, 2025 13:51
@youennf youennf added the merge-queue Applied to send a pull request to merge-queue label Jun 2, 2025
https://bugs.webkit.org/show_bug.cgi?id=293319
rdar://problem/152111446

Reviewed by Per Arne Vollan and Chris Dumez.

Make sure that JSAbortController marks its signal reason to prevent GC.

* LayoutTests/http/tests/fetch/abort-signal-gc-expected.txt:
* LayoutTests/http/tests/fetch/abort-signal-gc.html:
* Source/WebCore/dom/AbortController.cpp:
(WebCore::JSAbortController::visitAdditionalChildren):
* Source/WebCore/dom/AbortController.idl:

Canonical link: https://commits.webkit.org/295688@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/AbortController-signal-reason-is-lost-after-garbage-collection branch from aa016ad to f1292b5 Compare June 2, 2025 15:50
@webkit-commit-queue
Copy link
Copy Markdown
Collaborator

Committed 295688@main (f1292b5): https://commits.webkit.org/295688@main

Reviewed commits have been landed. Closing PR #45986 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f1292b5 into WebKit:main Jun 2, 2025
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DOM For bugs specific to XML/HTML DOM elements (including parsing).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants