[Safe CPP] Address Warnings in RenderFrame and HTMLFrameElement by stwrt · Pull Request #46235 · WebKit/WebKit

stwrt · 2025-06-03T00:28:51Z

`4af4465`

[Safe CPP] Address Warnings in RenderFrame and HTMLFrameElement
https://bugs.webkit.org/show_bug.cgi?id=293931
rdar://problem/152464519

Reviewed by Chris Dumez.

Address safe cpp warnings in RenderFrame and HTMLFrameElement.

* Source/WebCore/html/HTMLFrameElement.cpp:
(WebCore::HTMLFrameElement::attributeChanged):
* Source/WebCore/html/HTMLFrameElement.h:
* Source/WebCore/rendering/RenderFrame.cpp:
(WebCore::RenderFrame::frameElement const):
(WebCore::RenderFrame::edgeInfo const):
* Source/WebCore/rendering/RenderFrame.h:
(WebCore::HTMLFrameElement::renderer const):

Canonical link: https://commits.webkit.org/295787@main

d1e96c3

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-06-03T00:28:58Z

EWS run on previous version of this PR (hash 69fe000)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🛠 wpe-cairo~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🛠 gtk~~
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	~~🛠 tv-sim~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2025-06-03T00:31:58Z

EWS run on previous version of this PR (hash 65a9cca)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	⏳ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

cdumez · 2025-06-03T00:47:58Z

This is against our style. Our getters do not return smart pointers. Sometimes, we do have a second getter which is named protectedFoo() or checkedFoo() which return a Ref or a CheckedRef. I'm not sure this is helpful here since this is nullable and the caller will likely have to store the result in a local variable (which can be a CheckedPtr) in order to null check it.

Addressed the requested style changes.

webkit-ews-buildbot · 2025-06-03T04:00:42Z

Safer C++ Build #38446 (`65a9cca`)

⚠️ Found 1 fixed file! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

Tools/Scripts/update-safer-cpp-expectations -p WebCore --UncheckedLocalVarsChecker html/HTMLFrameElement.cpp --UncountedLocalVarsChecker html/HTMLFrameElement.cpp

webkit-early-warning-system · 2025-06-03T04:13:02Z

EWS run on previous version of this PR (hash b910232)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~	~~🛠 playstation~~
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-06-03T04:16:32Z

EWS run on previous version of this PR (hash 8eacea0)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2025-06-03T05:39:50Z

Safer C++ Build #38462 (`b910232`)

⚠️ Found 1 fixed file! Please update expectations in Source/[Project]/SaferCPPExpectations by running the following command and update your pull request:

Tools/Scripts/update-safer-cpp-expectations -p WebCore --UncheckedLocalVarsChecker html/HTMLFrameElement.cpp --UncountedLocalVarsChecker html/HTMLFrameElement.cpp

webkit-ews-buildbot · 2025-06-03T06:04:31Z

Safer C++ Build #38464 (`8eacea0`)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-early-warning-system · 2025-06-03T13:37:25Z

EWS run on previous version of this PR (hash 45da766)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	❌ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2025-06-03T14:54:33Z

Safer C++ Build #38506 (`45da766`)

❌ Found 1 failing file with 1 issue. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming.
(cc @rniwa)

webkit-early-warning-system · 2025-06-03T16:36:34Z

EWS run on previous version of this PR (hash 3f791e3)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	~~🛠 win~~
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~	~~🧪 win-tests~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🧪 api-wpe~~
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	✅ 🛠 wpe-cairo
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	⏳ 🧪 mac-AS-debug-wk2	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	~~🧪 mac-wk2-stress~~	~~🧪 api-gtk~~
	~~🧪 vision-wk2~~	~~🧪 mac-intel-wk2~~	~~🛠 playstation~~
	✅ 🛠 tv	~~🛠 mac-safer-cpp~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-06-03T16:39:59Z

EWS run on previous version of this PR (hash 3da04c9)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	⏳ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🛠 gtk
	✅ 🛠 vision	~~🧪 mac-AS-debug-wk2~~	~~🧪 gtk-wk2~~
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2025-06-03T18:15:58Z

EWS run on current version of this PR (hash d1e96c3)

Details

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	⏳ 🧪 win-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
	✅ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
✅ 🛠 🧪 merge	✅ 🧪 vision-wk2	✅ 🧪 mac-intel-wk2	✅ 🛠 playstation
	✅ 🛠 tv	✅ 🛠 mac-safer-cpp
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-ews-buildbot · 2025-06-03T23:50:25Z

Failed api-wpe checks. Please resolve failures and re-apply safe-merge-queue label.

Rejecting #46235 from merge queue.

webkit-ews-buildbot · 2025-06-03T23:50:42Z

Safe-Merge-Queue: Build #59268.

https://bugs.webkit.org/show_bug.cgi?id=293931 rdar://problem/152464519 Reviewed by Chris Dumez. Address safe cpp warnings in RenderFrame and HTMLFrameElement. * Source/WebCore/html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::attributeChanged): * Source/WebCore/html/HTMLFrameElement.h: * Source/WebCore/rendering/RenderFrame.cpp: (WebCore::RenderFrame::frameElement const): (WebCore::RenderFrame::edgeInfo const): * Source/WebCore/rendering/RenderFrame.h: (WebCore::HTMLFrameElement::renderer const): Canonical link: https://commits.webkit.org/295787@main

webkit-commit-queue · 2025-06-04T00:54:09Z

Committed 295787@main (4af4465): https://commits.webkit.org/295787@main

Reviewed commits have been landed. Closing PR #46235 and removing active labels.

stwrt requested review from cdumez and rniwa as code owners June 3, 2025 00:28

stwrt self-assigned this Jun 3, 2025

stwrt added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jun 3, 2025

stwrt force-pushed the eng/render_frame branch from 69fe000 to 65a9cca Compare June 3, 2025 00:31

cdumez reviewed Jun 3, 2025

View reviewed changes

cdumez requested changes Jun 3, 2025

View reviewed changes

Comment thread Source/WebCore/rendering/RenderFrame.h Outdated

Comment thread Source/WebCore/rendering/RenderFrame.h Outdated

stwrt force-pushed the eng/render_frame branch from 65a9cca to b910232 Compare June 3, 2025 04:12

stwrt changed the title ~~[Safe CPP] Address Warnings in RenderFrame~~ [Safe CPP] Address Warnings in RenderFrame and HTMLFrameElement Jun 3, 2025

stwrt force-pushed the eng/render_frame branch from b910232 to 8eacea0 Compare June 3, 2025 04:16

stwrt requested a review from cdumez June 3, 2025 04:16

cdumez approved these changes Jun 3, 2025

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 3, 2025

nt1m reviewed Jun 3, 2025

View reviewed changes

Comment thread Source/WebCore/rendering/RenderFrame.cpp Outdated

stwrt removed the merging-blocked Applied to prevent a change from being merged label Jun 3, 2025

stwrt force-pushed the eng/render_frame branch from 8eacea0 to 45da766 Compare June 3, 2025 13:37

stwrt requested a review from nt1m June 3, 2025 13:37

stwrt added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 3, 2025

nt1m reviewed Jun 3, 2025

View reviewed changes

Comment thread Source/WebCore/html/HTMLFrameElement.cpp Outdated

nt1m reviewed Jun 3, 2025

View reviewed changes

Comment thread Source/WebCore/rendering/RenderFrame.cpp Outdated

stwrt removed the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 3, 2025

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 3, 2025

cdumez self-requested a review June 3, 2025 15:48

stwrt removed the merging-blocked Applied to prevent a change from being merged label Jun 3, 2025

stwrt force-pushed the eng/render_frame branch from 45da766 to 3f791e3 Compare June 3, 2025 16:36

stwrt requested a review from nt1m June 3, 2025 16:36

stwrt force-pushed the eng/render_frame branch from 3f791e3 to 3da04c9 Compare June 3, 2025 16:39

cdumez approved these changes Jun 3, 2025

View reviewed changes

stwrt force-pushed the eng/render_frame branch from 3da04c9 to d1e96c3 Compare June 3, 2025 18:15

stwrt added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Jun 3, 2025

webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Jun 3, 2025

stwrt added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jun 4, 2025

webkit-commit-queue force-pushed the eng/render_frame branch from d1e96c3 to 4af4465 Compare June 4, 2025 00:54

webkit-commit-queue merged commit 4af4465 into WebKit:main Jun 4, 2025

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 4, 2025

Conversation

stwrt commented Jun 3, 2025 • edited by webkit-early-warning-system Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

4af4465

Uh oh!

webkit-early-warning-system commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cdumez Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

stwrt Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

webkit-ews-buildbot commented Jun 3, 2025

Safer C++ Build #38446 (65a9cca)

Uh oh!

webkit-early-warning-system commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented Jun 3, 2025

Safer C++ Build #38462 (b910232)

Uh oh!

Uh oh!

webkit-ews-buildbot commented Jun 3, 2025

Safer C++ Build #38464 (8eacea0)

Uh oh!

webkit-early-warning-system commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

webkit-ews-buildbot commented Jun 3, 2025

Safer C++ Build #38506 (45da766)

Uh oh!

webkit-early-warning-system commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-early-warning-system commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

webkit-ews-buildbot commented Jun 3, 2025

Uh oh!

webkit-ews-buildbot commented Jun 3, 2025

Uh oh!

webkit-commit-queue commented Jun 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

stwrt commented Jun 3, 2025 •

edited by webkit-early-warning-system

Loading

`4af4465`

webkit-early-warning-system commented Jun 3, 2025 •

edited

Loading

webkit-early-warning-system commented Jun 3, 2025 •

edited

Loading

Safer C++ Build #38446 (`65a9cca`)

webkit-early-warning-system commented Jun 3, 2025 •

edited

Loading

webkit-early-warning-system commented Jun 3, 2025 •

edited

Loading

Safer C++ Build #38462 (`b910232`)

Safer C++ Build #38464 (`8eacea0`)

webkit-early-warning-system commented Jun 3, 2025 •

edited

Loading

Safer C++ Build #38506 (`45da766`)

webkit-early-warning-system commented Jun 3, 2025 •

edited

Loading

webkit-early-warning-system commented Jun 3, 2025 •

edited

Loading

webkit-early-warning-system commented Jun 3, 2025 •

edited

Loading